You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/17 20:54:41 UTC

[GitHub] [incubator-gobblin] shirshanka commented on a change in pull request #2928: GOBBLIN-1087: Track and report histogram of observed lag from Gobblin…

shirshanka commented on a change in pull request #2928: GOBBLIN-1087: Track and report histogram of observed lag from Gobblin…
URL: https://github.com/apache/incubator-gobblin/pull/2928#discussion_r393964368
 
 

 ##########
 File path: gobblin-modules/gobblin-kafka-common/build.gradle
 ##########
 @@ -44,6 +46,9 @@ dependencies {
   testCompile project(":gobblin-test-utils")
   testCompile externalDependency.mockito
   testCompile externalDependency.testng
+
+  jmh 'org.openjdk.jmh:jmh-core:1.17.3'
 
 Review comment:
   Now that we seem to have multiple modules using jmh, can you move out the version definition to common place like definitions.gradle and refer to it like we refer to them normally? 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services