You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/18 11:18:50 UTC
[GitHub] [incubator-seatunnel] leo65535 opened a new pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
leo65535 opened a new pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
For detail, please go to
ISSUE: https://github.com/apache/incubator-seatunnel/issues/788
Lists: https://lists.apache.org/thread/ml880ltvp1lbgtgcm9n5ynyw5kr6406y
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#issuecomment-1017192772
> wo should delete BatchTableEnvironment and delete old planner default use blink planner
> i think FlinkStreamSink,we show use RowData instead of Row
Thanks @chaozwn for your advice. This issue is the first step to upgrade the flink version, we will make changes step by step as you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#issuecomment-1015315314
cc @CalvinKirs @wolfboys @garyelephant, take a review when you are free, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#issuecomment-1017192772
> wo should delete BatchTableEnvironment and delete old planner default use blink planner
> i think FlinkStreamSink,we show use RowData instead of Row
Thanks @chaozwn for your advice. This patch is the first step to upgrade the flink version, we will make changes step by step as you mentioned. And this patch ensures the original components are available as much as possible.
BTW, if you are interested in this feature, please leave a message under https://github.com/apache/incubator-seatunnel/issues/788 and I will assign it to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#issuecomment-1021797712
If any new Jar binary package adding to your PR, please add License Notice according
New License Guide: https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] chaozwn commented on pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
chaozwn commented on pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#issuecomment-1017167336
wo should delete BatchTableEnvironment and delete old planner default use blink planner. In batch mode,
StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
env.setRuntimeMode(RuntimeExecutionMode.BATCH);
this is blink planner batch mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on a change in pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
yx91490 commented on a change in pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#discussion_r801744486
##########
File path: seatunnel-connectors/seatunnel-connector-flink-jdbc/src/main/java/org/apache/seatunnel/flink/sink/JdbcSink.java
##########
@@ -94,20 +90,21 @@ public void prepare(FlinkEnvironment env) {
}
private void createSink(TableEnvironment tableEnvironment, Table table) {
- TypeInformation<?>[] fieldTypes = table.getSchema().getFieldTypes();
- String[] fieldNames = table.getSchema().getFieldNames();
- TableSink sink = JDBCAppendTableSink.builder()
- .setDrivername(driverName)
- .setDBUrl(dbUrl)
- .setUsername(username)
- .setPassword(password)
- .setBatchSize(batchSize)
- .setQuery(query)
- .setParameterTypes(fieldTypes)
- .build()
- .configure(fieldNames, fieldTypes);
- String uniqueTableName = SchemaUtil.getUniqueTableName();
- tableEnvironment.registerTableSink(uniqueTableName, sink);
- table.insertInto(uniqueTableName);
+ /* TypeInformation<?>[] fieldTypes = table.getSchema().getFieldTypes();
+ String[] fieldNames = table.getSchema().getFieldNames();
+ TableSink sink = JDBCAppendTableSink.builder()
+ .setDrivername(driverName)
+ .setDBUrl(dbUrl)
+ .setUsername(username)
+ .setPassword(password)
+ .setBatchSize(batchSize)
+ .setQuery(query)
+ .setParameterTypes(fieldTypes)
+ .build()
+ .configure(fieldNames, fieldTypes);
+ String uniqueTableName = SchemaUtil.getUniqueTableName();
+ tableEnvironment.registerTableSink(uniqueTableName, sink);
+ table.insertInto(uniqueTableName);
+ */
Review comment:
@leo65535 can you explain why comment these code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#issuecomment-1017192772
> wo should delete BatchTableEnvironment and delete old planner default use blink planner
> i think FlinkStreamSink,we show use RowData instead of Row
Thanks @chaozwn for your advice. This patch is the first step to upgrade the flink version, we will make changes step by step as you mentioned. And this patch ensures the original components are available as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#issuecomment-1022100964
> If any new Jar binary package adding to your PR, please add License Notice according New License Guide: https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md
Thank you for reminding me, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#issuecomment-1019631651
cc @CalvinKirs @wolfboys @garyelephant, take a review when you are free, we need upgrade the version as soon as posible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] chaozwn commented on a change in pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
chaozwn commented on a change in pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#discussion_r788392398
##########
File path: seatunnel-connectors/seatunnel-connector-flink-jdbc/src/main/java/org/apache/seatunnel/flink/sink/JdbcSink.java
##########
@@ -17,23 +17,19 @@
package org.apache.seatunnel.flink.sink;
-import org.apache.seatunnel.shade.com.typesafe.config.Config;
-import org.apache.seatunnel.common.config.CheckConfigUtil;
-import org.apache.seatunnel.flink.FlinkEnvironment;
-import org.apache.seatunnel.flink.batch.FlinkBatchSink;
-import org.apache.seatunnel.flink.stream.FlinkStreamSink;
-import org.apache.seatunnel.flink.util.SchemaUtil;
-import org.apache.seatunnel.common.config.CheckResult;
-import org.apache.flink.api.common.typeinfo.TypeInformation;
import org.apache.flink.api.java.DataSet;
-import org.apache.flink.api.java.io.jdbc.JDBCAppendTableSink;
import org.apache.flink.api.java.operators.DataSink;
import org.apache.flink.streaming.api.datastream.DataStream;
import org.apache.flink.streaming.api.datastream.DataStreamSink;
import org.apache.flink.table.api.Table;
import org.apache.flink.table.api.TableEnvironment;
-import org.apache.flink.table.sinks.TableSink;
import org.apache.flink.types.Row;
+import org.apache.seatunnel.common.config.CheckConfigUtil;
+import org.apache.seatunnel.common.config.CheckResult;
+import org.apache.seatunnel.flink.FlinkEnvironment;
+import org.apache.seatunnel.flink.batch.FlinkBatchSink;
+import org.apache.seatunnel.flink.stream.FlinkStreamSink;
+import org.apache.seatunnel.shade.com.typesafe.config.Config;
public class JdbcSink implements FlinkStreamSink<Row, Row>, FlinkBatchSink<Row, Row> {
Review comment:
i think FlinkStreamSink,we show use RowData instead of Row,inteface should be DataStreamSink<RowData> and DataStreamSource<RowData>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] cody195 commented on pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
cody195 commented on pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#issuecomment-1021759637
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089#issuecomment-1031262301
Thanks @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1089: [Feature] [flink] Upgrade flink to 1.13.5
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1089:
URL: https://github.com/apache/incubator-seatunnel/pull/1089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org