[GitHub] svatoun commented on a change in pull request #361: my first refactoring session

[GitBox <gi...@apache.org>]

svatoun commented on a change in pull request #361: my first refactoring session
URL: https://github.com/apache/incubator-netbeans/pull/361#discussion_r161164235
 
 

 ##########
 File path: refactoring.api/src/org/netbeans/modules/refactoring/api/RefactoringSession.java
 ##########
 @@ -210,34 +189,32 @@ public void start(ProgressEvent event) {
 
         @Override
         public void step(ProgressEvent event) {
-            current = current + progressStep;
+            current += progressStep;
             fireProgressListenerStep((int) current);
         }
 
         @Override
         public void stop(ProgressEvent event) {
-            // do not rely on plugins;
+            /* do not rely on plugins; */
 
 Review comment:
   Line comment was specifically invented for realy short notes and it's faster to type than /* - */ pair. I don't see a point to change it for one-liners. Maybe for long multilines.
   It would be more useful to extend the toggle comment feature to:
   - make a block comment (maybe a different hotkey or an additional modifier)
   - turn block of line comments into block comment or vice versa
   
   Whether to use multilines or block comments depend on personal or group development style - it's not a defect to fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists