You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/09/24 10:36:13 UTC
[GitHub] [dolphinscheduler] ruanwenjun opened a new issue #6336: [Bug] [UT] UT failed in DAO module
ruanwenjun opened a new issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When I run the UT in `TaskInstanceMapperTest`, it failed.
The `process_definition_code` is null.
```java
### SQL: INSERT INTO t_ds_process_instance ( warning_group_id, timeout, executor_id, max_try_times, tenant_id, command_param, run_times, process_definition_version ) VALUES ( ?, ?, ?, ?, ?, ?, ?, ? )
### Cause: java.sql.SQLException: Field 'process_definition_code' doesn't have a default value
; Field 'process_definition_code' doesn't have a default value; nested exception is java.sql.SQLException: Field 'process_definition_code' doesn't have a default value
```
### What you expected to happen
UT execute success.
### How to reproduce
Execute TaskInstanceMapperTest.
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-929501392
> @EricPyZhou Can you find this file?
> 
To update the database, do I just run sh ./script/upgrade-dolphinscheduler like in this instruction: https://dolphinscheduler.apache.org/en-us/docs/1.3.2/user_doc/upgrade.html?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-928780523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930746529
> @EricPyZhou Of course, you can fix the sql file, but you need to make sure this change is accepted by the community. I remember there was a pr has discussed the default value, you can find.
@ruanwenjun From what I read from here:
api模块进行save操作时
通过雪花算法生成13位的数字作为process_definition_code，工作流定义保存至process_definition（主表）和process_definition_log（日志表），这两个表保存的是同样的数据，工作流定义版本为1
作者：政采云大数据团队
链接：https://juejin.cn/post/7004640905806217252
来源：稀土掘金
I think I can just use the quick fix in `before` in `TaskInstanceMapperTest` (manually set `process_definition_code` ) because there is essentially no need to give it a default value when the definition code can be generated by the snowflake algorithm every time a workflow is saved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930704778
> @EricPyZhou You shouldn't modify the sql file, you just need to fix this UT, right? There are two problems.
This is a quick fix, how do you find it? @ruanwenjun
PS: If I create a new issue to modify the ddl sql (gives `process_definition_code` a default value), this UT can be resolved automatically without any change. But, I am not sure if this modification is aligned with the original design idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
ruanwenjun edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930697479
@EricPyZhou You shouldn't modify the sql file, you just need to fix this UT, right?
There are two problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou removed a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou removed a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-929501392
> @EricPyZhou Can you find this file?
> 
To update the database, do I just run sh ./script/upgrade-dolphinscheduler like in this instruction: https://dolphinscheduler.apache.org/en-us/docs/1.3.2/user_doc/upgrade.html?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou removed a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou removed a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930706189
> > @EricPyZhou You shouldn't modify the sql file, you just need to fix this UT, right? There are two problems.
>
> This is a quick fix to pass all tests, how do you find it? @ruanwenjun 
>
> But if I create a new issue to fix the ddl sql issue, this UT can be resolved automatically without any change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
ruanwenjun edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930708111
@EricPyZhou Of course, you can fix the sql file, but you need to make sure this change is accepted by the community. I remember there was a pr has discussed the default value, you can find.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930704778
> @EricPyZhou You shouldn't modify the sql file, you just need to fix this UT, right? There are two problems.
This is a quick fix, how do you find it? @ruanwenjun
But if I create a new issue to fix the ddl sql issue, this UT can be resolved automatically without any change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930704778
> @EricPyZhou You shouldn't modify the sql file, you just need to fix this UT, right? There are two problems.
This is a quick fix, how do you find it? @ruanwenjun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-928780523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930746529
> @EricPyZhou Of course, you can fix the sql file, but you need to make sure this change is accepted by the community. I remember there was a pr has discussed the default value, you can find.
From what I read from here:
api模块进行save操作时
通过雪花算法生成13位的数字作为process_definition_code，工作流定义保存至process_definition（主表）和process_definition_log（日志表），这两个表保存的是同样的数据，工作流定义版本为1
作者：政采云大数据团队
链接：https://juejin.cn/post/7004640905806217252
来源：稀土掘金
I think I can just use the quick fix in `before` in `TaskInstanceMapperTest` (manually set `process_definition_code` ) because there is essentially no need to give it a default value when the definition code can be generated by the snowflake algorithm every time a workflow is saved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930710890
> @EricPyZhou Of course, you can fix the sql file, but you need to make sure this change is accepted by the community. I remember there was a pr has discussed the default value, you can find.
I will give it a look. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930788971
@EricPyZhou I think your plan is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-928780523
> @EricPyZhou There miss some ddl sql in `upgrade` sql file. You can just use `dolphinscheduler_mysql.sql` to create the latest schema. If you have time, you can create a new issue to fix the ddl sql.
I don't really find any dolphinscheduler_mysql.sql under sql directory. Is there another sql file I should use to get the latest schema? Or I can just run UpgradeDolphinScheduler in DAO module
For the ddl sql in sql/upgrade directory, which version of schema are we using in dev branch. I checked the version in the root ppm.xml, but it says 2.0 SNAPSHOT, which can not be associated to any version under the upgrade directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-927521961
@ruanwenjun When I run `TaskInstanceMapperTest`, the failed test showed the log:
Which is a different one, btw I'm on the latest dev branch.
Based on my error log, I went to the table and indeed did not find any column named `process_definition_version`
Can you also double-check on your local environment so that we can confirm that this failure is reproducible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-928894652
@EricPyZhou Can you find this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-927521961
When I run `TaskInstanceMapperTest`, the failed test showed the log:
Which is a different one, btw I'm on the latest dev branch.
Based on my error log, I went to the table and indeed did not find any column named `process_definition_version`
Can you also double-check on your local environment so that we can confirm that this failure is reproducible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou removed a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou removed a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-929501392
> @EricPyZhou Can you find this file?
> 
To update the database, do I just run sh ./script/upgrade-dolphinscheduler like in this instruction: https://dolphinscheduler.apache.org/en-us/docs/1.3.2/user_doc/upgrade.html?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-928893922
> @EricPyZhou https://github.com/apache/dolphinscheduler/tree/dev/sql
I'll look at the implementation in more details. This link is honestly not that helpful...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930708111
@EricPyZhou Of cause, you can fix the sql file, but you need to make sure this change is accepted by the community. I remember there was a pr has discussed the default value, you can find.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-927835697
@EricPyZhou There miss some ddl sql in `upgrade` sql file. You can just use `dolphinscheduler_mysql.sql` to create the latest schema. If you have time, you can create a new issue to fix the ddl sql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-931593097
@ruanwenjun Can you help review this PR. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930689951
Updates on this issue. @ruanwenjun
1. tests are all failed at line 69 because the processInstance object here does not have the attribute `processDefinitionCode`, and the field `process_definition_code` is NOT NULL. Therefore my solution is to add the default value to the field.
2. I am not sure where to put
SQL ALTER TABLE t_ds_process_instance MODIFY COLUMN `process_definition_code` bigint(20) not NULL COMMENT 'process definition code' AFTER `worker_group`;
Should I put it into sql/upgrade/1.4.0_scheme/mysql/dolphinscheduler_ddl.sql? or just modify directly in dolphinscheduler_mysql.sql?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-928780523
> @EricPyZhou There miss some ddl sql in `upgrade` sql file. You can just use `dolphinscheduler_mysql.sql` to create the latest schema. If you have time, you can create a new issue to fix the ddl sql.
I don't really find any dolphinscheduler_mysql.sql under sql directory. Is there another sql file I should use to get the latest schema? Or I can just run UpgradeDolphinScheduler in DAO module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-928896481
> @EricPyZhou Can you find this file?
> 
>
Oh Yes. I didn't see it. For some reason, it didn't pop up in the search result on Github. My bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930697479
@EricPyZhou You shouldn't modified the sql file, you just need to fix this UT, right?
There are two problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930706189
> > @EricPyZhou You shouldn't modify the sql file, you just need to fix this UT, right? There are two problems.
>
> This is a quick fix to pass all tests, how do you find it? @ruanwenjun 
>
> But if I create a new issue to fix the ddl sql issue, this UT can be resolved automatically without any change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-928891298
@EricPyZhou https://github.com/apache/dolphinscheduler/tree/dev/sql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou edited a comment on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou edited a comment on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-927521961
@ruanwenjun When I run `TaskInstanceMapperTest`, the failed test showed the log:
Which is a different one, btw I'm on the latest dev branch.
Based on my error log, I went to the table and indeed did not find any column named `process_definition_version`
Can you also double-check on your local environment so that we can confirm that this failure is reproducible?
PS: I rerun `CreateDolphinScheduler` after pulling the lastest change just to make sure my db schemes are the latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-928896481
> @EricPyZhou Can you find this file?
> 
>
Oh Yes. I don't see it. For some reason, it does not pop up in the search result on Github. My bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-928891298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-928780523
> @EricPyZhou There miss some ddl sql in `upgrade` sql file. You can just use `dolphinscheduler_mysql.sql` to create the latest schema. If you have time, you can create a new issue to fix the ddl sql.
I don't really find any dolphinscheduler_mysql.sql under sql directory. Is there another sql file I should use to get the latest schema?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricPyZhou commented on issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
EricPyZhou commented on issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336#issuecomment-930704778
> are
If I only need to fix the UT, I can
> @EricPyZhou You shouldn't modify the sql file, you just need to fix this UT, right? There are two problems.
This is a quick fix, how do you find it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs closed issue #6336: [Bug] [UT] UT failed in DAO module
Posted by GitBox <gi...@apache.org>.
CalvinKirs closed issue #6336:
URL: https://github.com/apache/dolphinscheduler/issues/6336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org