You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/11/15 01:50:56 UTC

[GitHub] [incubator-tvm] jackwish commented on a change in pull request #4338: AutoTVM: selecting tuning templates when extracting task

jackwish commented on a change in pull request #4338: AutoTVM: selecting tuning templates when extracting task
URL: https://github.com/apache/incubator-tvm/pull/4338#discussion_r346632104
 
 

 ##########
 File path: python/tvm/autotvm/task/relay_integration.py
 ##########
 @@ -98,6 +103,8 @@ def extract_from_multiple_program(funcs, params, ops, target, target_host=None):
         The compilation target
     target_host: tvm.target.Target
         The host compilation target
+    template_key: str
 
 Review comment:
   That is good point. I have also considered such design, though I thought it was complicating things... While relay ops are mapped to TOPI op, which implements different templates, the `template_keys` needs to be a dict of TOPI op to keys. I will update this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services