You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/08 16:23:18 UTC
[jira] [Commented] (IGNITE-5455) .NET: Incorrect binary object hash
code calculation
[ https://issues.apache.org/jira/browse/IGNITE-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042956#comment-16042956 ]
ASF GitHub Bot commented on IGNITE-5455:
----------------------------------------
GitHub user ptupitsyn opened a pull request:
https://github.com/apache/ignite/pull/2108
IGNITE-5455 .NET: Fix binary hash code calculation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptupitsyn/ignite ignite-5455
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/2108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2108
----
commit df1e9d6431a2e9fb61789b3c56c1c9b5d3fc114a
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T14:36:54Z
wip
commit 8da992f3fdbbbfd536d042c4d2dcfa709cddd1e6
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T14:37:59Z
wip
commit 8ddbf99b7b1c2d26d208bc1bdf1ca45591736f1d
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T14:40:08Z
wip
commit 1af859b04b81ef1a9c4daa776c8d5e98df125144
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T15:16:07Z
fix hash code computation and tests
commit d3fb2c47005231cbdcc4860718b218f2af4bf1f6
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T15:22:21Z
wip
commit 19775feb0c5ab56033f8dffc45b74fd7b48738ef
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T15:24:22Z
wip
commit 845dd12c47fac9caff5a4ba170fae11725d752eb
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T15:56:58Z
Improving tests
commit d6cc6d13cf485f2d5f4d0e146ccdadca096dd1dd
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T16:01:51Z
wip
commit 393b946a0a344ab853407005552b5ecba1e08ad3
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T16:02:46Z
wip tests
commit c090323b4f819b68b3ba20a008763a2d654af88e
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T16:07:53Z
wip
commit 29f3024b681a615715e46aaf0c08b052f1b7e8cd
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T16:08:36Z
wip tests
commit f8e76ae370692f45a98a9ceaf1180fc8d90d3160
Author: Pavel Tupitsyn <pt...@apache.org>
Date: 2017-06-08T16:14:39Z
Adding tests
----
> .NET: Incorrect binary object hash code calculation
> ---------------------------------------------------
>
> Key: IGNITE-5455
> URL: https://issues.apache.org/jira/browse/IGNITE-5455
> Project: Ignite
> Issue Type: Bug
> Components: platforms
> Affects Versions: 2.0
> Reporter: Pavel Tupitsyn
> Assignee: Pavel Tupitsyn
> Priority: Critical
> Labels: .NET
> Fix For: 2.1
>
>
> Hash code is calculated over binary object data with the following code in Java and .NET:
> {code}
> for (int i = start; i <= end; i++)
> hash = 31 * hash + data[i];
> {code}
> Where {{data}} is {{byte[]}} in Java and .NET.
> And {{byte}} is signed in Java and unsigned in .NET.
> So in our simple tests on small values it works, but fails on real world data.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)