[GitHub] [superset] eschutho commented on a change in pull request #19243: fix: cannot delete a database if team member has SQL editor tab that uses that db

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #19243:
URL: https://github.com/apache/superset/pull/19243#discussion_r840974418



##########
File path: superset/migrations/versions/58df9d617f14_add_on_saved_query_delete_tab_state_.py
##########
@@ -17,14 +17,14 @@
 """add_on_saved_query_delete_tab_state_null_constraint"
 
 Revision ID: 58df9d617f14
-Revises: 6766938c6065
+Revises: 8b841273bec3
 Create Date: 2022-03-16 23:24:40.278937
 
 """
 
 # revision identifiers, used by Alembic.
 revision = "58df9d617f14"
-down_revision = "6766938c6065"
+down_revision = "8b841273bec3"

Review comment:
       @diegomedina248 this is going to be tricky to change a down revision for a migration that has already merged, especially for people who have already run this migration. Is there any reason why the new file can't run after this one?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org