You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/12/01 01:48:19 UTC
Re: Review Request 64102: Renamed curl target to libcurl,
and staging of curl.exe on Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64102/#review192430
-----------------------------------------------------------
3rdparty/CMakeLists.txt
Lines 614-617 (patched)
<https://reviews.apache.org/r/64102/#comment270577>
Nit picking on style, we usually break do each component on a line if it's multi-line. I'll fix when I commit.
This probably also needs a comment explaining what it does to non CMake experts.
- Andrew Schwartzmeyer
On Nov. 30, 2017, 9:18 a.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64102/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 9:18 a.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed curl target to libcurl, and staging of curl.exe on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt c34b65d5ff306e17c3519667ae303a8678fca43d
>
>
> Diff: https://reviews.apache.org/r/64102/diff/1/
>
>
> Testing
> -------
>
> Ran all tests on Windows/Linux (for this patch plus #64103 and #64104). No related tests failed on either Linux or Windows.
>
>
> Thanks,
>
> John Kordich
>
>