[GitHub] [tez] abstractdog commented on a diff in pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4

["abstractdog (via GitHub)" <gi...@apache.org>]

abstractdog commented on code in PR #272:
URL: https://github.com/apache/tez/pull/272#discussion_r1113872811


##########
tez-tests/pom.xml:
##########
@@ -124,11 +124,34 @@
       <artifactId>junit</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-core</artifactId>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <groupId>org.bouncycastle</groupId>
       <artifactId>bcprov-jdk15on</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-core</artifactId>
+      <version>2.18.0</version>

Review Comment:
   this test-scoped dependency is included twice in this pom, is that intentional? also, its version differs from the one in the root pom (4.3.1), can you place a comment here about that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org