You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/25 15:48:36 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #11061: chore: Clean up some console warnings
kgabryje opened a new pull request #11061:
URL: https://github.com/apache/incubator-superset/pull/11061
### SUMMARY
I bumped some dependencies and did some prop types changes in order to clean up browser console warnings.
Unfortunately, in a few cases we use pretty old versions of some libraries and upgrading them would require major refactors (e.g. react-bootstrap).
Moreover, some libraries that use deprecated react lifecycle methods don't have updates available that would introduce fixes.
For those reasons, there's still quite a lot of noise in the console... but not as much as before 🙂
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11061: chore: Clean up some console warnings
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11061:
URL: https://github.com/apache/incubator-superset/pull/11061#discussion_r495670380
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -96,7 +96,7 @@ export default class AddSliceContainer extends React.PureComponent<
<Panel.Body>
<div>
<p>{t('Choose a datasource')}</p>
- <p>
+ <div style={{ marginBottom: '10px' }}>
Review comment:
Is this wrapper div even necessary? Or should the div within, `<div style={styleSelectWidth}>` just have this margin added there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11061: chore: Clean up some console warnings
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11061:
URL: https://github.com/apache/incubator-superset/pull/11061#discussion_r496089722
##########
File path: superset-frontend/src/dashboard/components/BuilderComponentPane.jsx
##########
@@ -47,7 +47,7 @@ class BuilderComponentPane extends React.PureComponent {
renderTabs(height) {
const { isSticky } = this.props;
return (
- <Tabs className="m-t-10 tabs-components">
+ <Tabs className="m-t-10 tabs-components" id="tabs">
Review comment:
Ahh, ok, thanks :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11061: chore: Clean up some console warnings
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11061:
URL: https://github.com/apache/incubator-superset/pull/11061#discussion_r495841416
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -96,7 +96,7 @@ export default class AddSliceContainer extends React.PureComponent<
<Panel.Body>
<div>
<p>{t('Choose a datasource')}</p>
- <p>
+ <div style={{ marginBottom: '10px' }}>
Review comment:
You're right, it wasn't necessary. I renamed `styleSelectWidth` to `styleSelectContainer` and removed this style from `<Select>` (it wasn't necessary)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11061: chore: Clean up some console warnings
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11061:
URL: https://github.com/apache/incubator-superset/pull/11061#discussion_r495670843
##########
File path: superset-frontend/src/dashboard/components/BuilderComponentPane.jsx
##########
@@ -47,7 +47,7 @@ class BuilderComponentPane extends React.PureComponent {
renderTabs(height) {
const { isSticky } = this.props;
return (
- <Tabs className="m-t-10 tabs-components">
+ <Tabs className="m-t-10 tabs-components" id="tabs">
Review comment:
Doesn't seem objectionable, but I'm curious what this fixes!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #11061: chore: Clean up some console warnings
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #11061:
URL: https://github.com/apache/incubator-superset/pull/11061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11061: chore: Clean up some console warnings
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11061:
URL: https://github.com/apache/incubator-superset/pull/11061#issuecomment-699029631
@rusackas Can you please take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11061: chore: Clean up some console warnings
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11061:
URL: https://github.com/apache/incubator-superset/pull/11061#discussion_r495840889
##########
File path: superset-frontend/src/dashboard/components/BuilderComponentPane.jsx
##########
@@ -47,7 +47,7 @@ class BuilderComponentPane extends React.PureComponent {
renderTabs(height) {
const { isSticky } = this.props;
return (
- <Tabs className="m-t-10 tabs-components">
+ <Tabs className="m-t-10 tabs-components" id="tabs">
Review comment:
It's required by Tabs component, otherwise this warning is generated:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #11061: chore: Clean up some console warnings
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11061:
URL: https://github.com/apache/incubator-superset/pull/11061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org