[jira] [Commented] (FLINK-3646) Use Processing-Time Clock in Window Assigners/Triggers

["Kostas Kloudas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335951#comment-15335951 ] 

Kostas Kloudas commented on FLINK-3646:
---------------------------------------

The solution to this in included in https://github.com/apache/flink/pull/2124

> Use Processing-Time Clock in Window Assigners/Triggers
> ------------------------------------------------------
>
>                 Key: FLINK-3646
>                 URL: https://issues.apache.org/jira/browse/FLINK-3646
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Streaming
>    Affects Versions: 1.0.0
>            Reporter: Aljoscha Krettek
>            Assignee: Kostas Kloudas
>
> This is part of the effort to improve Window Triggers in Flink. We should replace all usage of {{System.currentTimeMillis()}} by a provided clock implementation. This way we can use a deterministic testing clock to verify the behavior of processing-time windowing components in unit tests.
> This requires the following changes:
> - Change {{StreamTask}} to have a {{Clock}} (name is WIP). By default this clock will use {{System.currentTimeMillis()}}. The clock must also provide an interface to register processing-time triggers, this is currently handled directly by {{StreamTask}} but must now also be handled by an external Clock
> - Change API of {{WindowAssigner}} to take a context object that allows it to query the current processing time. This can be an abstract class {{AssignerContext}} with a single method {{long currentProcessingTime()}}
> - Add a method {{long currentProcessingTime()}} in {{TriggerContext}}, change {{TriggerContext}} to use the clock methods provided by {{StreamTask}} and forwarded by {{WindowOperator}}
> - Change processing-time triggers to use the new methods
> - Change {{WindowOperator}} to support these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)