You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/04 02:11:04 UTC
[jira] [Commented] (NIFI-3793) nifi-toolkit-admin uses
client.version of 1.2.0-SNAPSHOT
[ https://issues.apache.org/jira/browse/NIFI-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996042#comment-15996042 ]
ASF GitHub Bot commented on NIFI-3793:
--------------------------------------
GitHub user YolandaMDavis opened a pull request:
https://github.com/apache/nifi/pull/1748
NIFI-3793 - switch to use project.version
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YolandaMDavis/nifi NIFI-3793
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1748.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1748
----
commit a50f71498bf57e191a24c1967bdd7d42ba3110f9
Author: Yolanda M. Davis <yo...@gmail.com>
Date: 2017-05-04T02:08:43Z
NIFI-3793 - switch to use project.version
----
> nifi-toolkit-admin uses client.version of 1.2.0-SNAPSHOT
> --------------------------------------------------------
>
> Key: NIFI-3793
> URL: https://issues.apache.org/jira/browse/NIFI-3793
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Bryan Bende
> Assignee: Yolanda M. Davis
> Priority: Blocker
> Fix For: 1.2.0
>
>
> The nifi-toolkit pom declares client.version which is currently set to 1.2.0-SNAPSHOT, and then nifi-toolkit-admin has a dependency on nifi-client-dto using client.version.
> The problem is that the release plugin will not automatically update client.version and then if you build with a clean Maven repo (or someone who never built master while at 1.2.0-SNAPSHOT) you get a failure:
> nifi-toolkit-admin: Could not resolve dependencies for project org.apache.nifi:nifi-toolkit-admin:jar:1.2.0: The following artifacts could not be resolved: org.apache.nifi:nifi-client-dto:jar:1.2.0-SNAPSHOT, org.apache.nifi:nifi-web-security:jar:1.2.0-SNAPSHOT: Failure to find org.apache.nifi:nifi-client-dto:jar:1.2.0-SNAPSHOT
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)