You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/02 07:58:58 UTC
[GitHub] [ozone] wycccccc opened a new pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
wycccccc opened a new pull request #1648:
URL: https://github.com/apache/ozone/pull/1648
## What changes were proposed in this pull request?
Renamed `ozone.datanode.pipeline.limit` a suitable name.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4449
## How was this patch tested?
no test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#issuecomment-749048190
Thanx @wycccccc , @adoroszlai and @jojochuang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#issuecomment-742831273
Not that familiar with Ozone code but can we try using this kind of Hadoop configuration APIs?
https://github.com/apache/hadoop/blob/b69ac575a1a02d39c64c6cf998ec2ef4eb5918cd/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/HdfsConfiguration.java#L70
```
Configuration.addDeprecations(new DeprecationDelta[]{
new DeprecationDelta("dfs.backup.address",
DeprecatedKeys.DFS_NAMENODE_BACKUP_ADDRESS_KEY),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] wycccccc commented on pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
wycccccc commented on pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#issuecomment-744169723
Thanks @adoroszlai review, I have removed old config key and pass`TestOzoneConfigurationFields`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#discussion_r542209202
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/conf/OzoneConfiguration.java
##########
@@ -293,8 +294,11 @@ public Properties getAllPropertiesByTag(String tag) {
return configMap;
}
+
private static void addDeprecatedKeys(){
Configuration.addDeprecations(new DeprecationDelta[]{
+ new DeprecationDelta("ozone.datanode.pipeline.limit",
+ ScmConfigKeys.OZONE_DATANODE_PIPELINE_LIMIT)
Review comment:
```suggestion
ScmConfigKeys.OZONE_DATANODE_PIPELINE_LIMIT),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] wycccccc commented on pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
wycccccc commented on pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#issuecomment-740651817
Thanks for reminding @ayushtkn ，you are right. I will add deprecation to avoid compatibility issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] wycccccc commented on pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
wycccccc commented on pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#issuecomment-743075273
Thanks for your suggestion @jojochuang , I found a similar method in ozone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#issuecomment-739135075
Is directly changing the conf fine? Don't we need to deprecate the existing one? To maintain compatibility, or is that not the case here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#discussion_r543884222
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/conf/OzoneConfiguration.java
##########
@@ -293,8 +294,11 @@ public Properties getAllPropertiesByTag(String tag) {
return configMap;
}
+
Review comment:
nit: Remove the new line change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn merged pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
ayushtkn merged pull request #1648:
URL: https://github.com/apache/ozone/pull/1648
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] wycccccc commented on pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
wycccccc commented on pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#issuecomment-743078688
Thanks for your help @adoroszlai. I have corrected this, I am not sure if it is appropriate to change it here, do you think it is feasible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#issuecomment-744284282
/ready
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#issuecomment-743151015
Thanks @wycccccc for adding the deprecation. It reminded me to merge your other similar PR. Now there is a conflict in this PR. Sorry for the inconvenience. Since `TestOzoneConfigurationFields` failure is caused by the changes here, a minor update is needed anyway: old config key name is leftover in the XML.
https://github.com/apache/ozone/blob/d02659c802a55366ed5d42176f83fd3917f3526c/hadoop-hdds/common/src/main/resources/ozone-default.xml#L779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1648: HDDS-4449. Rename config ozone.datanode.pipeline.limit
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1648:
URL: https://github.com/apache/ozone/pull/1648#issuecomment-742696963
/pending I will add deprecation to avoid compatibility issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org