You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/03/16 23:09:54 UTC
[PR] Auto-upgrade sphinx-airflow-theme in prek hook [airflow]
potiuk opened a new pull request, #63763:
URL: https://github.com/apache/airflow/pull/63763
Add sphinx-airflow-theme to the upgrade-important-versions prek hook so it
automatically fetches the latest version from
https://airflow.apache.org/sphinx-airflow-theme/LATEST_VERSION.txt and updates
the whl URL in `devel-common/pyproject.toml`.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Opus 4.6 (1M context)
Generated-by: Claude Opus 4.6 (1M context) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-upgrade sphinx-airflow-theme in prek hook [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #63763:
URL: https://github.com/apache/airflow/pull/63763#discussion_r2943572538
##########
.pre-commit-config.yaml:
##########
@@ -1063,10 +1046,20 @@ repos:
^airflow-core/src/airflow/api_fastapi/core_api/datamodels/.*\.py$|
^airflow-core/src/airflow/api_fastapi/auth/managers/simple/(datamodels|routes|services|openapi)/.*\.py$
require_serial: true
- ## ONLY ADD PREK HOOKS HERE THAT REQUIRE CI IMAGE
- id: check-contextmanager-class-decorators
name: Check for problematic context manager class decorators
entry: ./scripts/ci/prek/check_contextmanager_class_decorators.py
language: python
files: .*test.*\.py$
pass_filenames: true
+ - id: update-uv-lock
Review Comment:
This is run only by `breeze ci upgrade` step
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-upgrade sphinx-airflow-theme in prek hook [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #63763:
URL: https://github.com/apache/airflow/pull/63763#discussion_r2943571066
##########
.pre-commit-config.yaml:
##########
@@ -998,8 +980,19 @@ repos:
pass_filenames: false
files: ^dev/breeze/src/airflow_breeze/global_constants\.py$
require_serial: true
+ - id: update-uv-lock
Review Comment:
This is fast, local uv sync - run every time pyproject.toml changes locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-upgrade sphinx-airflow-theme in prek hook [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #63763:
URL: https://github.com/apache/airflow/pull/63763#discussion_r2943572538
##########
.pre-commit-config.yaml:
##########
@@ -1063,10 +1046,20 @@ repos:
^airflow-core/src/airflow/api_fastapi/core_api/datamodels/.*\.py$|
^airflow-core/src/airflow/api_fastapi/auth/managers/simple/(datamodels|routes|services|openapi)/.*\.py$
require_serial: true
- ## ONLY ADD PREK HOOKS HERE THAT REQUIRE CI IMAGE
- id: check-contextmanager-class-decorators
name: Check for problematic context manager class decorators
entry: ./scripts/ci/prek/check_contextmanager_class_decorators.py
language: python
files: .*test.*\.py$
pass_filenames: true
+ - id: update-uv-lock
Review Comment:
This is run only by `breeze ci upgrade` step. It needs to be run in the image in order to make sure we resolve all potential dependencues from all providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-upgrade sphinx-airflow-theme in prek hook [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #63763:
URL: https://github.com/apache/airflow/pull/63763#discussion_r2943617458
##########
.pre-commit-config.yaml:
##########
@@ -1063,10 +1046,20 @@ repos:
^airflow-core/src/airflow/api_fastapi/core_api/datamodels/.*\.py$|
^airflow-core/src/airflow/api_fastapi/auth/managers/simple/(datamodels|routes|services|openapi)/.*\.py$
require_serial: true
- ## ONLY ADD PREK HOOKS HERE THAT REQUIRE CI IMAGE
- id: check-contextmanager-class-decorators
name: Check for problematic context manager class decorators
entry: ./scripts/ci/prek/check_contextmanager_class_decorators.py
language: python
files: .*test.*\.py$
pass_filenames: true
+ - id: update-uv-lock
Review Comment:
Good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-upgrade sphinx-airflow-theme in prek hook [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #63763:
URL: https://github.com/apache/airflow/pull/63763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-upgrade sphinx-airflow-theme in prek hook [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #63763:
URL: https://github.com/apache/airflow/pull/63763#discussion_r2943531702
##########
.pre-commit-config.yaml:
##########
@@ -1063,10 +1046,20 @@ repos:
^airflow-core/src/airflow/api_fastapi/core_api/datamodels/.*\.py$|
^airflow-core/src/airflow/api_fastapi/auth/managers/simple/(datamodels|routes|services|openapi)/.*\.py$
require_serial: true
- ## ONLY ADD PREK HOOKS HERE THAT REQUIRE CI IMAGE
- id: check-contextmanager-class-decorators
name: Check for problematic context manager class decorators
entry: ./scripts/ci/prek/check_contextmanager_class_decorators.py
language: python
files: .*test.*\.py$
pass_filenames: true
+ - id: update-uv-lock
Review Comment:
This needs to be run at the end as it needs CI image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-upgrade sphinx-airflow-theme in prek hook [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #63763:
URL: https://github.com/apache/airflow/pull/63763#discussion_r2943588875
##########
.pre-commit-config.yaml:
##########
@@ -1063,10 +1046,20 @@ repos:
^airflow-core/src/airflow/api_fastapi/core_api/datamodels/.*\.py$|
^airflow-core/src/airflow/api_fastapi/auth/managers/simple/(datamodels|routes|services|openapi)/.*\.py$
require_serial: true
- ## ONLY ADD PREK HOOKS HERE THAT REQUIRE CI IMAGE
- id: check-contextmanager-class-decorators
name: Check for problematic context manager class decorators
entry: ./scripts/ci/prek/check_contextmanager_class_decorators.py
language: python
files: .*test.*\.py$
pass_filenames: true
+ - id: update-uv-lock
Review Comment:
probably adding a comment in the pre-commit file on top of this hook would be better if someone moves this or adds any hooks after this might lead extra issues ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-upgrade sphinx-airflow-theme in prek hook [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63763:
URL: https://github.com/apache/airflow/pull/63763#issuecomment-4071861411
### Backport failed to create: v3-1-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/23175172827'> Run details </a>
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-1-test</td>
<td><a href="https://github.com/apache/airflow/commit/5c77949d28fb22d54114aaa6d50843224c12716c"><img src='https://img.shields.io/badge/Commit-5c77949-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker 5c77949 v3-1-test
```
This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#how-to-backport-pr-with-cherry-picker-cli).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org