You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/10 06:24:16 UTC

[GitHub] [arrow] kou opened a new pull request, #34997: GH-34995: [C++] Improve available GTest check for SYSTEM case

kou opened a new pull request, #34997:
URL: https://github.com/apache/arrow/pull/34997

   ### Rationale for this change
   
   The `GTest_SOURCE=AUTO` case worked without this but the `GTest_SOURCE=SYSTEM` case didn't. On conda environment, `SYSTEM` is used. So this is needed for conda environment.
   
   ### What changes are included in this PR?
   
   Raises an error in the `GTest_SOURCE=SYSTEM` case.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   Yes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zfoobar commented on pull request #34997: GH-34995: [C++] Improve available GTest check for SYSTEM case

Posted by "zfoobar (via GitHub)" <gi...@apache.org>.
zfoobar commented on PR #34997:
URL: https://github.com/apache/arrow/pull/34997#issuecomment-1501460181

   Error raised:
   
   - Found GTest: /Users/zacharyfierstadt/miniconda3/envs/pyarrow-dev/lib/cmake/GTest/GTestConfig.cmake (found suitable version "1.13.0", minimum required is "1.10.0")  
   -- GTest can't be used with C++17. Use -DGTest_SOURCE=BUNDLED.
   CMake Error at /Users/zacharyfierstadt/miniconda3/envs/pyarrow-dev/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
     Could NOT find GTestAlt (missing: GTestAlt_CXX_STANDARD_AVAILABLE)
     (Required is at least version "1.10.0")
   Call Stack (most recent call first):
     /Users/zacharyfierstadt/miniconda3/envs/pyarrow-dev/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
     cmake_modules/FindGTestAlt.cmake:60 (find_package_handle_standard_args)
     cmake_modules/ThirdpartyToolchain.cmake:280 (find_package)
     cmake_modules/ThirdpartyToolchain.cmake:2218 (resolve_dependency)
     CMakeLists.txt:506 (include)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #34997: GH-34995: [C++] Improve available GTest check for SYSTEM case

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34997:
URL: https://github.com/apache/arrow/pull/34997#issuecomment-1501450339

   :warning: GitHub issue #34995 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #34997: GH-34995: [C++] Improve available GTest check for SYSTEM case

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34997:
URL: https://github.com/apache/arrow/pull/34997#issuecomment-1502588287

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #34997: GH-34995: [C++] Improve available GTest check for SYSTEM case

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34997:
URL: https://github.com/apache/arrow/pull/34997#issuecomment-1501450253

   @zfoobar Could you try this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #34997: GH-34995: [C++] Improve available GTest check for SYSTEM case

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34997:
URL: https://github.com/apache/arrow/pull/34997#issuecomment-1501463134

   Thanks. It's expected because `-DARROW_SOURCE_DEPENDENCY=SYSTEM` by default on conda environment.
   
   If you specify `-DGTest_SOURCE=AUTO` explicitly, you can use vendored GoogleTest automatically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zfoobar commented on pull request #34997: GH-34995: [C++] Improve available GTest check for SYSTEM case

Posted by "zfoobar (via GitHub)" <gi...@apache.org>.
zfoobar commented on PR #34997:
URL: https://github.com/apache/arrow/pull/34997#issuecomment-1501462961

   @kou thanks for bringing the catch back in. Just wondering: is there any reason not to automatically fall back to BUNDLED in this situation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #34997: GH-34995: [C++] Improve available GTest check for SYSTEM case

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34997:
URL: https://github.com/apache/arrow/pull/34997#issuecomment-1501450316

   * Closes: #34995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #34997: GH-34995: [C++] Improve available GTest check for SYSTEM case

Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34997:
URL: https://github.com/apache/arrow/pull/34997#issuecomment-1503891254

   Benchmark runs are scheduled for baseline = c7ba0cd2cbdd89bce7d58edf573a9d3c16cf647d and contender = c70c3d51c0cadaf1be060df5d56f00b9761c79de. c70c3d51c0cadaf1be060df5d56f00b9761c79de is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7ee467436bd3404baad820150c9f2928...4cab1401af0d4ead91b0b245e3c6a31c/)
   [Finished :arrow_down:0.62% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/688a40d8eaa8475a86c7bc15fb257c20...c74850e05f4f4cafb0ae88656436af22/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/627d67d7e32148619669b832f85121c6...d8f9daac14e5410a8438f1de524c5a56/)
   [Failed :arrow_down:0.31% :arrow_up:0.4%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4a25477e4edb4f2b97c2c6b129846060...aefc9645ec4a47df9046d1d0a24fb7fa/)
   Buildkite builds:
   [Finished] [`c70c3d51` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2671)
   [Finished] [`c70c3d51` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2704)
   [Finished] [`c70c3d51` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2669)
   [Finished] [`c70c3d51` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2695)
   [Finished] [`c7ba0cd2` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2670)
   [Finished] [`c7ba0cd2` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2703)
   [Finished] [`c7ba0cd2` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2668)
   [Failed] [`c7ba0cd2` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2694)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou merged pull request #34997: GH-34995: [C++] Improve available GTest check for SYSTEM case

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34997:
URL: https://github.com/apache/arrow/pull/34997


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org