You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2009/09/17 01:41:57 UTC

[jira] Created: (HIVE-840) no error if user specifies multiple columns of same name as output

no error if user specifies multiple columns of same name as output
------------------------------------------------------------------

                 Key: HIVE-840
                 URL: https://issues.apache.org/jira/browse/HIVE-840
             Project: Hadoop Hive
          Issue Type: Bug
          Components: Query Processor
            Reporter: Namit Jain


INSERT OVERWRITE TABLE table_name_here
SELECT TRANSFORM(key,val)
USING '/script/'
AS foo, foo, foo


The above query should fail, but it succeeds

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HIVE-840) no error if user specifies multiple columns of same name as output

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain resolved HIVE-840.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 0.5.0
     Hadoop Flags: [Reviewed]

Committed. Thanks Yongqiang

> no error if user specifies multiple columns of same name as output
> ------------------------------------------------------------------
>
>                 Key: HIVE-840
>                 URL: https://issues.apache.org/jira/browse/HIVE-840
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>             Fix For: 0.5.0
>
>         Attachments: hive-840-2009-10-28.patch, hive-840-2009-10-29.patch
>
>
> INSERT OVERWRITE TABLE table_name_here
> SELECT TRANSFORM(key,val)
> USING '/script/'
> AS foo, foo, foo
> The above query should fail, but it succeeds

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-840) no error if user specifies multiple columns of same name as output

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-840:
------------------------------

    Attachment: hive-840-2009-10-29.patch

Integrated Namit's suggestions. Thanks, Namit!

> no error if user specifies multiple columns of same name as output
> ------------------------------------------------------------------
>
>                 Key: HIVE-840
>                 URL: https://issues.apache.org/jira/browse/HIVE-840
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: hive-840-2009-10-28.patch, hive-840-2009-10-29.patch
>
>
> INSERT OVERWRITE TABLE table_name_here
> SELECT TRANSFORM(key,val)
> USING '/script/'
> AS foo, foo, foo
> The above query should fail, but it succeeds

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-840) no error if user specifies multiple columns of same name as output

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-840:
------------------------------

    Attachment: hive-840-2009-10-28.patch

> no error if user specifies multiple columns of same name as output
> ------------------------------------------------------------------
>
>                 Key: HIVE-840
>                 URL: https://issues.apache.org/jira/browse/HIVE-840
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>         Attachments: hive-840-2009-10-28.patch
>
>
> INSERT OVERWRITE TABLE table_name_here
> SELECT TRANSFORM(key,val)
> USING '/script/'
> AS foo, foo, foo
> The above query should fail, but it succeeds

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HIVE-840) no error if user specifies multiple columns of same name as output

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain reassigned HIVE-840:
-------------------------------

    Assignee: He Yongqiang

Looks good - just one minor comment.

Can you add the error message in ErrorMsg.java and then use it

> no error if user specifies multiple columns of same name as output
> ------------------------------------------------------------------
>
>                 Key: HIVE-840
>                 URL: https://issues.apache.org/jira/browse/HIVE-840
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: hive-840-2009-10-28.patch
>
>
> INSERT OVERWRITE TABLE table_name_here
> SELECT TRANSFORM(key,val)
> USING '/script/'
> AS foo, foo, foo
> The above query should fail, but it succeeds

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-840) no error if user specifies multiple columns of same name as output

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771573#action_12771573 ] 

Namit Jain commented on HIVE-840:
---------------------------------

There are existing error messages which are used with parameters: look at TABLE_ALREADY_EXISTS.
Cant you follow the same approach ? The only restriction is that the column name will appear at the end,
which might be acceptable.

> no error if user specifies multiple columns of same name as output
> ------------------------------------------------------------------
>
>                 Key: HIVE-840
>                 URL: https://issues.apache.org/jira/browse/HIVE-840
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: hive-840-2009-10-28.patch
>
>
> INSERT OVERWRITE TABLE table_name_here
> SELECT TRANSFORM(key,val)
> USING '/script/'
> AS foo, foo, foo
> The above query should fail, but it succeeds

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-840) no error if user specifies multiple columns of same name as output

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771562#action_12771562 ] 

He Yongqiang commented on HIVE-840:
-----------------------------------

Thanks, Namit. 
You mean the error message ""column alias " + name + " already exists."  We need a parameter 'name' in the error message, so it may not fit in ErrorMsg.

> no error if user specifies multiple columns of same name as output
> ------------------------------------------------------------------
>
>                 Key: HIVE-840
>                 URL: https://issues.apache.org/jira/browse/HIVE-840
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>         Attachments: hive-840-2009-10-28.patch
>
>
> INSERT OVERWRITE TABLE table_name_here
> SELECT TRANSFORM(key,val)
> USING '/script/'
> AS foo, foo, foo
> The above query should fail, but it succeeds

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.