[GitHub] [iceberg] rdblue commented on pull request #1140: ORC: skip non-iceberg columns when converting schema to Iceberg

[GitBox <gi...@apache.org>]

rdblue commented on pull request #1140:
URL: https://github.com/apache/iceberg/pull/1140#issuecomment-652720632


   @edgarRd, this looks good to me. The only problem is with the tests, which assert sizes instead of schema structure. I think it's probably best to be more specific about _which_ fields are converted.
   
   You may also consider moving the conversion visitor out of the util class and into its own file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org