You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "yangzhiyuss (via GitHub)" <gi...@apache.org> on 2023/09/06 01:10:21 UTC

[GitHub] [seatunnel] yangzhiyuss commented on a diff in pull request #5428: [FixBug][HdfsSource]Filter out empty and dirty files

yangzhiyuss commented on code in PR #5428:
URL: https://github.com/apache/seatunnel/pull/5428#discussion_r1316574239


##########
seatunnel-connectors-v2/connector-file/connector-file-base-hadoop/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/hdfs/source/BaseHdfsFileSource.java:
##########
@@ -110,13 +112,26 @@ public void prepare(Config pluginConfig) throws PrepareFailException {
                             "SeaTunnel does not supported this file format");
             }
         } else {
-            try {
-                rowType = readStrategy.getSeaTunnelRowTypeInfo(hadoopConf, filePaths.get(0));
-            } catch (FileConnectorException e) {
+            FileConnectorException fileConnectorException = null;

Review Comment:
   Sometimes during data migration, some such files will be generated due to the network or hadoop system itself, but hadoop itself will not take the initiative to clean up。



##########
seatunnel-connectors-v2/connector-file/connector-file-base-hadoop/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/hdfs/source/BaseHdfsFileSource.java:
##########
@@ -110,13 +112,26 @@ public void prepare(Config pluginConfig) throws PrepareFailException {
                             "SeaTunnel does not supported this file format");
             }
         } else {
-            try {
-                rowType = readStrategy.getSeaTunnelRowTypeInfo(hadoopConf, filePaths.get(0));
-            } catch (FileConnectorException e) {
+            FileConnectorException fileConnectorException = null;

Review Comment:
   Sometimes during data migration, some such files will be generated due to the network or hadoop system itself, but hadoop itself will not take the initiative to clean up。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org