[GitHub] [doris] zenoyang commented on a diff in pull request #10278: [Improvement] remove olap filters when use in key ranges

[GitBox <gi...@apache.org>]

zenoyang commented on code in PR #10278:
URL: https://github.com/apache/doris/pull/10278#discussion_r902152097


##########
be/src/exec/olap_common.h:
##########
@@ -258,6 +258,9 @@ class OlapScanKeys {
     template <class T>
     Status extend_scan_key(ColumnValueRange<T>& range, int32_t max_scan_key_num);
 
+    template <class T>
+    Status extend_scan_key(ColumnValueRange<T>& range, int32_t max_scan_key_num, bool* exact_value);
+

Review Comment:
   The implementations of `Status extend_scan_key(ColumnValueRange<T>& range, int32_t max_scan_key_num);` and `Status extend_scan_key(ColumnValueRange<T>& range, int32_t max_scan_key_num, bool* exact_value);` are very similar, I think they can be combined into one, just give `exact_value` a default value `nullptr` when the function is declared. Before assigning a value to `*exact_value`, first determine whether `exact_value` is `nullptr`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org