You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/16 06:00:35 UTC

[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3991: [KYUUBI #3990] Support for translating `SELECT TABLE_CAT FROM system.jdbc.catalogs` to `Getcatalogs` operation in Trino front protocol

yaooqinn commented on code in PR #3991:
URL: https://github.com/apache/incubator-kyuubi/pull/3991#discussion_r1050397398


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -265,8 +268,12 @@ class KyuubiSessionImpl(
           runAsync,
           command)
         runOperation(operation)
+      case translateNode: TrinoTranslatorNode if frontendProtocol == TRINO =>

Review Comment:
   Things get crazy 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org