[GitHub] [skywalking] wu-sheng commented on a change in pull request #4844: update the kubernetes client verion to 8.0.0 and refactor kubernetes …

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4844:
URL: https://github.com/apache/skywalking/pull/4844#discussion_r440183182



##########
File path: dist-material/release-docs/LICENSE
##########
@@ -216,6 +216,7 @@ The following components are provided under the Apache License. See project link
 The text of each license is also included at licenses/LICENSE-[project].txt.
 
     Apache: httpcomponents 4.x.x: http://hc.apache.org/index.html, Apache 2.0
+    Apache: fastjson 1.2.58:  https://github.com/alibaba/fastjson, Apache 2.0

Review comment:
       Fastjson should have been removed.

##########
File path: dist-material/release-docs/LICENSE
##########
@@ -304,12 +306,13 @@ The text of each license is the standard Apache 2.0 license.
     HikariCP 3.1.0: https://github.com/brettwooldridge/HikariCP, Apache 2.0
     zipkin 2.9.1: https://github.com/openzipkin/zipkin, Apache 2.0
     sharding-jdbc-core 2.0.3: https://github.com/sharding-sphere/sharding-sphere, Apache 2.0
-    kubernetes-client 4.0.0: https://github.com/kubernetes-client/java, Apache 2.0
+    kubernetes-client 8.0.0: https://github.com/kubernetes-client/java, Apache 2.0
     proto files from istio/istio: https://github.com/istio/istio  Apache 2.0
     proto files from istio/api: https://github.com/istio/api      Apache 2.0
     consul-client 1.2.6: https://github.com/rickfast/consul-client, Apache 2.0
     okhttp 3.9.0: https://github.com/square/okhttp, Apache 2.0
     prometheus client_java 0.6.0: https://github.com/prometheus/client_java, Apache 2.0
+    nacos 1.2.0: https://github.com/alibaba/nacos, Apache 2.0

Review comment:
       Nacos should be removed too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org