[GitHub] spark pull request: [WIP][SPARK-14402][CORE] initcap UDF doesn't m...

[dongjoon-hyun <gi...@git.apache.org>]

Github user dongjoon-hyun commented on the pull request:

    https://github.com/apache/spark/pull/12175#issuecomment-205902962
  
    Hi, @srowen . I minimized the change on master.
    * Undo the changes on `common` module.
    * Implement `initCap` by the following changes.
    ```
       override def nullSafeEval(string: Any): Any = {
    -    string.asInstanceOf[UTF8String].toTitleCase
    +    string.asInstanceOf[UTF8String].toLowerCase.toTitleCase
       }
       override def genCode(ctx: CodegenContext, ev: ExprCode): String = {
    -    defineCodeGen(ctx, ev, str => s"$str.toTitleCase()")
    +    defineCodeGen(ctx, ev, str => s"$str.toLowerCase().toTitleCase()")
       }
    ```
    I think it's enough for `initCap` function as a small fix for now. How do you think about this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org