You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/03/14 23:16:28 UTC

[GitHub] [lucene] Yuti-G edited a comment on pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

Yuti-G edited a comment on pull request #747:
URL: https://github.com/apache/lucene/pull/747#issuecomment-1067392546


   > Thanks for picking this up! I've looked at everything except for your overridden implementation in SSDV faceting, but since I may run out of time to look at that today, I'll go ahead and publish my feedback on your default implementation and testing. I'll follow up with more feedback soon. Thanks again!
   
   Thanks @gsmiller for reviewing my PR and leaving the detailed feedback! I will address them in my next PR, appreciated :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org