[GitHub] [incubator-superset] rusackas commented on a change in pull request #11211: refactor: Replace react-bootstrap tabs with Antd tabs on Profile

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #11211:
URL: https://github.com/apache/incubator-superset/pull/11211#discussion_r508194451



##########
File path: superset-frontend/src/common/components/Dropdown.tsx
##########
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Dropdown as AntdDropdown } from 'src/common/components';
+import { css } from '@emotion/core';
+import { styled } from '@superset-ui/core';
+
+const dotStyle = css`
+  width: 3px;
+  height: 3px;
+  border-radius: 1.5px;
+  background-color: #bababa;
+`;

Review comment:
       Would like to see these four properties pulled from the theme... i.e. gridUnit (4px) and `grayscale.light1` for the gray. Also, fractional pixels round to the nearest pixel in browsers at 100%. Unless we're trying to get fancy with zooming, 2px  (or gridUnit / 2) should work here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org