You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/20 17:19:08 UTC

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold

anoopsjohn commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold
URL: https://github.com/apache/hbase/pull/1074#discussion_r368657370
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
 ##########
 @@ -1118,17 +1125,19 @@ private HStoreFile commitFile(Path path, long logCacheFlushId, MonitoredTask sta
   // compaction
   public StoreFileWriter createWriterInTmp(long maxKeyCount, Compression.Algorithm compression,
       boolean isCompaction, boolean includeMVCCReadpoint, boolean includesTag,
-      boolean shouldDropBehind) throws IOException {
+      boolean shouldDropBehind, long totalCompactedFileSize) throws IOException {
 
 Review comment:
   totalCompactedFile's'Size

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services