You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/02 04:34:43 UTC
[GitHub] [pulsar] dragonls opened a new pull request #9417: [Docs] Optimize helm deploy description about the first deployment (#9416)
dragonls opened a new pull request #9417:
URL: https://github.com/apache/pulsar/pull/9417
# Motivation
The `--set initialize=true` option is necessary for initializing bookie and pulsar cluster meta, which is not clear in current document.
# Modifications
Optimize helm deploy description about the first deployment as mentioned in #9416 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #9417: [Docs] Optimize helm deploy description about the first deployment (#9416)
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #9417:
URL: https://github.com/apache/pulsar/pull/9417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #9417: [Docs] Optimize helm deploy description about the first deployment (#9416)
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #9417:
URL: https://github.com/apache/pulsar/pull/9417#discussion_r569094961
##########
File path: site2/docs/helm-deploy.md
##########
@@ -350,6 +350,9 @@ helm upgrade --install pulsar apache/pulsar \
--timeout 10m \
--set [your configuration options]
```
+> **Note**
+>
+> For the first deployment, add `--set initialize=true` option to initialize bookie and pulsar cluster meta.
Review comment:
```suggestion
> For the first deployment, add `--set initialize=true` option to initialize bookie and Pulsar cluster metadata.
```
same comments on the following contents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #9417: [Docs] Optimize helm deploy description about the first deployment (#9416)
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #9417:
URL: https://github.com/apache/pulsar/pull/9417#discussion_r568371511
##########
File path: site2/docs/helm-deploy.md
##########
@@ -350,6 +350,7 @@ helm upgrade --install pulsar apache/pulsar \
--timeout 10m \
--set [your configuration options]
```
+> For the first deployment, add `--set initialize=true` option to initialize bookie and pulsar cluster meta.
Review comment:
Two questions:
1: it is a note? if yes, please use this format:
> **Note**
> For the first deployment, add `--set initialize=true` option to initialize bookie and Pulsar cluster metadata.
2: If this update is only available for master? if not, could you please help update docs in other releases? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dragonls commented on a change in pull request #9417: [Docs] Optimize helm deploy description about the first deployment (#9416)
Posted by GitBox <gi...@apache.org>.
dragonls commented on a change in pull request #9417:
URL: https://github.com/apache/pulsar/pull/9417#discussion_r568384213
##########
File path: site2/docs/helm-deploy.md
##########
@@ -350,6 +350,7 @@ helm upgrade --install pulsar apache/pulsar \
--timeout 10m \
--set [your configuration options]
```
+> For the first deployment, add `--set initialize=true` option to initialize bookie and pulsar cluster meta.
Review comment:
1: Yes, it is a note, will update.
2: It is also available for other release, will add PR for other releases.
##########
File path: site2/docs/helm-deploy.md
##########
@@ -350,6 +350,7 @@ helm upgrade --install pulsar apache/pulsar \
--timeout 10m \
--set [your configuration options]
```
+> For the first deployment, add `--set initialize=true` option to initialize bookie and pulsar cluster meta.
Review comment:
1: Yes, it is a note, will update.
2: It is also available for other release, will update docs in other releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dragonls commented on a change in pull request #9417: [Docs] Optimize helm deploy description about the first deployment (#9416)
Posted by GitBox <gi...@apache.org>.
dragonls commented on a change in pull request #9417:
URL: https://github.com/apache/pulsar/pull/9417#discussion_r568384213
##########
File path: site2/docs/helm-deploy.md
##########
@@ -350,6 +350,7 @@ helm upgrade --install pulsar apache/pulsar \
--timeout 10m \
--set [your configuration options]
```
+> For the first deployment, add `--set initialize=true` option to initialize bookie and pulsar cluster meta.
Review comment:
1: Yes, it is a note, will update.
2: It is also available for other release, will add PR for other releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dragonls commented on a change in pull request #9417: [Docs] Optimize helm deploy description about the first deployment (#9416)
Posted by GitBox <gi...@apache.org>.
dragonls commented on a change in pull request #9417:
URL: https://github.com/apache/pulsar/pull/9417#discussion_r569161181
##########
File path: site2/docs/helm-deploy.md
##########
@@ -350,6 +350,9 @@ helm upgrade --install pulsar apache/pulsar \
--timeout 10m \
--set [your configuration options]
```
+> **Note**
+>
+> For the first deployment, add `--set initialize=true` option to initialize bookie and pulsar cluster meta.
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #9417: [Docs] Optimize helm deploy description about the first deployment (#9416)
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #9417:
URL: https://github.com/apache/pulsar/pull/9417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dragonls commented on a change in pull request #9417: [Docs] Optimize helm deploy description about the first deployment (#9416)
Posted by GitBox <gi...@apache.org>.
dragonls commented on a change in pull request #9417:
URL: https://github.com/apache/pulsar/pull/9417#discussion_r568384213
##########
File path: site2/docs/helm-deploy.md
##########
@@ -350,6 +350,7 @@ helm upgrade --install pulsar apache/pulsar \
--timeout 10m \
--set [your configuration options]
```
+> For the first deployment, add `--set initialize=true` option to initialize bookie and pulsar cluster meta.
Review comment:
1: Yes, it is a note, will update.
2: It is also available for other release, will update docs in other releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #9417: [Docs] Optimize helm deploy description about the first deployment (#9416)
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #9417:
URL: https://github.com/apache/pulsar/pull/9417#discussion_r568371511
##########
File path: site2/docs/helm-deploy.md
##########
@@ -350,6 +350,7 @@ helm upgrade --install pulsar apache/pulsar \
--timeout 10m \
--set [your configuration options]
```
+> For the first deployment, add `--set initialize=true` option to initialize bookie and pulsar cluster meta.
Review comment:
Two questions:
1: it is a note? if yes, please use this format:
> **Note**
> For the first deployment, add `--set initialize=true` option to initialize bookie and Pulsar cluster metadata.
2: If this update is only available for master? if not, could you please help update docs in other releases? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org