You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/12/18 02:05:19 UTC

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19691: [v1.x] ONNX fix softmax

Zha0q1 commented on a change in pull request #19691:
URL: https://github.com/apache/incubator-mxnet/pull/19691#discussion_r545525290



##########
File path: tests/python-pytest/onnx/test_operators.py
##########
@@ -253,3 +254,16 @@ def test_onnx_export_dropout(tmp_path, dtype, p):
     M = def_model('Dropout', p=p)
     x = mx.nd.array([[3,0.5,-0.5,2,7],[2,-0.4,7,3,0.2]], dtype=dtype)
     op_export_test('Dropout', M, [x], tmp_path)
+
+@pytest.mark.parametrize('dtype', ['float16', 'float32'])
+def test_onnx_export_softmax(tmp_path, dtype):
+    x = mx.nd.random.uniform(0, 1, (2, 3, 4), dtype=dtype)

Review comment:
       sorry about nitpicking: shall we also test high dimensional + axis = middle dim cases?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org