You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by gr...@apache.org on 2021/05/10 12:58:07 UTC
[kudu] branch master updated (2741814 -> 04d3ba7)
This is an automated email from the ASF dual-hosted git repository.
granthenke pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git.
from 2741814 [thirdparty] Force Boost to use /dev/random for uuid
new 8e1d5ba [java] KUDU-3164: Add Java table comment support
new 04d3ba7 [python] KUDU-3164: Add Python table comment support
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../src/main/protobuf/backup.proto | 2 ++
.../org/apache/kudu/backup/TableMetadata.scala | 2 ++
.../org/apache/kudu/backup/TestKuduBackup.scala | 1 +
.../org/apache/kudu/client/AlterTableOptions.java | 10 +++++++
.../org/apache/kudu/client/AsyncKuduClient.java | 5 ++--
.../org/apache/kudu/client/CreateTableOptions.java | 11 ++++++++
.../apache/kudu/client/GetTableSchemaRequest.java | 3 ++-
.../apache/kudu/client/GetTableSchemaResponse.java | 14 +++++++++-
.../java/org/apache/kudu/client/KuduScanToken.java | 3 ++-
.../java/org/apache/kudu/client/KuduTable.java | 14 +++++++++-
.../java/org/apache/kudu/util/SchemaGenerator.java | 1 +
.../org/apache/kudu/client/TestAlterTable.java | 19 +++++++++++++
.../apache/kudu/client/TestAsyncKuduClient.java | 2 +-
.../org/apache/kudu/client/TestKeyEncoding.java | 6 ++---
python/kudu/client.pyx | 24 ++++++++++++++++-
python/kudu/libkudu_client.pxd | 3 +++
python/kudu/tests/test_client.py | 31 ++++++++++++++++++++++
17 files changed, 140 insertions(+), 11 deletions(-)
[kudu] 01/02: [java] KUDU-3164: Add Java table comment support
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
granthenke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 8e1d5ba4a8af06e82bbdb194393755554ae8e55d
Author: Grant Henke <gr...@apache.org>
AuthorDate: Thu May 6 13:42:03 2021 -0500
[java] KUDU-3164: Add Java table comment support
This patch adds table comment support to the Java client
and the backup and restore jobs.
Change-Id: If92cbb962f1d42a95ca64615ee943381284baff7
Reviewed-on: http://gerrit.cloudera.org:8080/17404
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
.../kudu-backup-common/src/main/protobuf/backup.proto | 2 ++
.../scala/org/apache/kudu/backup/TableMetadata.scala | 2 ++
.../scala/org/apache/kudu/backup/TestKuduBackup.scala | 1 +
.../org/apache/kudu/client/AlterTableOptions.java | 10 ++++++++++
.../java/org/apache/kudu/client/AsyncKuduClient.java | 5 +++--
.../org/apache/kudu/client/CreateTableOptions.java | 11 +++++++++++
.../org/apache/kudu/client/GetTableSchemaRequest.java | 3 ++-
.../apache/kudu/client/GetTableSchemaResponse.java | 14 +++++++++++++-
.../java/org/apache/kudu/client/KuduScanToken.java | 3 ++-
.../main/java/org/apache/kudu/client/KuduTable.java | 14 +++++++++++++-
.../java/org/apache/kudu/util/SchemaGenerator.java | 1 +
.../java/org/apache/kudu/client/TestAlterTable.java | 19 +++++++++++++++++++
.../org/apache/kudu/client/TestAsyncKuduClient.java | 2 +-
.../java/org/apache/kudu/client/TestKeyEncoding.java | 6 +++---
14 files changed, 83 insertions(+), 10 deletions(-)
diff --git a/java/kudu-backup-common/src/main/protobuf/backup.proto b/java/kudu-backup-common/src/main/protobuf/backup.proto
index 94c07c4..b0fa6f1 100644
--- a/java/kudu-backup-common/src/main/protobuf/backup.proto
+++ b/java/kudu-backup-common/src/main/protobuf/backup.proto
@@ -138,4 +138,6 @@ message TableMetadataPB {
map<string, PartitionMetadataPB> tablets = 11;
// The owner of the table.
string table_owner = 12;
+ // The comment on the table.
+ string table_comment = 13;
}
\ No newline at end of file
diff --git a/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala b/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
index 236349d..3bd2acc 100644
--- a/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
+++ b/java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
@@ -104,6 +104,7 @@ object TableMetadata {
.setPartitions(getPartitionSchemaMetadata(table))
.putAllTablets(tablets.asJava)
.setTableOwner(table.getOwner)
+ .setTableComment(table.getComment)
builder.build()
}
@@ -333,6 +334,7 @@ object TableMetadata {
if (restoreOwner) {
options.setOwner(metadata.getTableOwner)
}
+ options.setComment(metadata.getTableComment)
options.setNumReplicas(metadata.getNumReplicas)
metadata.getPartitions.getHashPartitionsList.asScala.foreach { hp =>
options
diff --git a/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala b/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
index 817875e..5ecd468 100644
--- a/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
+++ b/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
@@ -782,6 +782,7 @@ class TestKuduBackup extends KuduTestSuite {
assertNotEquals(tA.getOwner, tB.getOwner)
}
assertNotEquals("", tA.getOwner);
+ assertEquals(tA.getComment, tB.getComment)
assertEquals(tA.getNumReplicas, tB.getNumReplicas)
assertTrue(schemasMatch(tA.getSchema, tB.getSchema))
assertTrue(partitionSchemasMatch(tA.getPartitionSchema, tB.getPartitionSchema))
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java b/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
index 20aa80f..2f01d57 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
@@ -64,6 +64,16 @@ public class AlterTableOptions {
}
/**
+ * Change a table's comment.
+ * @param comment the new table comment
+ * @return this instance
+ */
+ public AlterTableOptions setComment(String comment) {
+ pb.setNewTableComment(comment);
+ return this;
+ }
+
+ /**
* Add a new column.
* @param colSchema the schema of the new column
* @return this instance
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java b/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
index 90edce4..35f8477 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
@@ -415,7 +415,7 @@ public class AsyncKuduClient implements AutoCloseable {
this.bootstrap = b.createBootstrap();
this.masterAddresses = b.masterAddresses;
this.masterTable = new KuduTable(this, MASTER_TABLE_NAME_PLACEHOLDER,
- MASTER_TABLE_NAME_PLACEHOLDER, null, null, 1, null, null);
+ MASTER_TABLE_NAME_PLACEHOLDER, null, null, 1, null, null, null);
this.defaultOperationTimeoutMs = b.defaultOperationTimeoutMs;
this.defaultAdminOperationTimeoutMs = b.defaultAdminOperationTimeoutMs;
this.statisticsDisabled = b.statisticsDisabled;
@@ -847,7 +847,8 @@ public class AsyncKuduClient implements AutoCloseable {
resp.getPartitionSchema(),
resp.getNumReplicas(),
resp.getExtraConfig(),
- resp.getOwner());
+ resp.getOwner(),
+ resp.getComment());
});
}
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java b/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
index 8949d2b..549d10b 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
@@ -259,6 +259,17 @@ public class CreateTableOptions {
return this;
}
+ /**
+ * Set the table comment.
+ *
+ * @param comment the table comment
+ * @return this instance
+ */
+ public CreateTableOptions setComment(String comment) {
+ pb.setComment(comment);
+ return this;
+ }
+
Master.CreateTableRequestPB.Builder getBuilder() {
if (!splitRows.isEmpty() || !rangePartitions.isEmpty()) {
pb.setSplitRowsRangeBounds(new Operation.OperationsEncoder()
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java b/java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
index 433ac4f..91eac64 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
@@ -101,7 +101,8 @@ public class GetTableSchemaRequest extends KuduRpc<GetTableSchemaResponse> {
ProtobufHelper.pbToPartitionSchema(respBuilder.getPartitionSchema(), schema),
respBuilder.hasAuthzToken() ? respBuilder.getAuthzToken() : null,
respBuilder.getExtraConfigsMap(),
- respBuilder.hasOwner() ? respBuilder.getOwner() : "");
+ respBuilder.hasOwner() ? respBuilder.getOwner() : "",
+ respBuilder.hasComment() ? respBuilder.getComment() : "");
return new Pair<GetTableSchemaResponse, Object>(
response, respBuilder.hasError() ? respBuilder.getError() : null);
}
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java b/java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
index 26b8723..dc72876 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
@@ -35,6 +35,7 @@ public class GetTableSchemaResponse extends KuduRpcResponse {
private final SignedTokenPB authzToken;
private final Map<String, String> extraConfig;
private final String owner;
+ private final String comment;
/**
* @param elapsedMillis Time in milliseconds since RPC creation to now
@@ -47,6 +48,7 @@ public class GetTableSchemaResponse extends KuduRpcResponse {
* @param authzToken an authorization token for use with this table
* @param extraConfig the table's extra configuration properties
* @param owner the table's owner
+ * @param owner the table's comment
*/
GetTableSchemaResponse(long elapsedMillis,
String tsUUID,
@@ -57,7 +59,8 @@ public class GetTableSchemaResponse extends KuduRpcResponse {
PartitionSchema partitionSchema,
SignedTokenPB authzToken,
Map<String, String> extraConfig,
- String owner) {
+ String owner,
+ String comment) {
super(elapsedMillis, tsUUID);
this.schema = schema;
this.partitionSchema = partitionSchema;
@@ -67,6 +70,7 @@ public class GetTableSchemaResponse extends KuduRpcResponse {
this.authzToken = authzToken;
this.extraConfig = extraConfig;
this.owner = owner;
+ this.comment = comment;
}
/**
@@ -132,4 +136,12 @@ public class GetTableSchemaResponse extends KuduRpcResponse {
public String getOwner() {
return owner;
}
+
+ /**
+ * Get the comment for the table.
+ * @return the table's comment
+ */
+ public String getComment() {
+ return comment;
+ }
}
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java b/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
index 1282a04..f864f98 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
@@ -366,7 +366,7 @@ public class KuduScanToken implements Comparable<KuduScanToken> {
return new KuduTable(client.asyncClient, tableMetadata.getTableName(),
tableMetadata.getTableId(), schema, partitionSchema,
tableMetadata.getNumReplicas(), tableMetadata.getExtraConfigsMap(),
- tableMetadata.getOwner());
+ tableMetadata.getOwner(), tableMetadata.getComment());
} else if (message.hasTableId()) {
return client.openTableById(message.getTableId());
} else {
@@ -495,6 +495,7 @@ public class KuduScanToken implements Comparable<KuduScanToken> {
.setTableId(table.getTableId())
.setTableName(table.getName())
.setOwner(table.getOwner())
+ .setComment(table.getComment())
.setNumReplicas(table.getNumReplicas())
.setSchema(ProtobufHelper.schemaToPb(table.getSchema()))
.setPartitionSchema(ProtobufHelper.partitionSchemaToPb(table.getPartitionSchema()))
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java b/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
index 4749fd4..b6fee17 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
@@ -51,6 +51,7 @@ public class KuduTable {
private final int numReplicas;
private final Map<String, String> extraConfig;
private final String owner;
+ private final String comment;
/**
* Package-private constructor, use {@link KuduClient#openTable(String)} to get an instance.
@@ -62,10 +63,11 @@ public class KuduTable {
* @param numReplicas this table's replication factor
* @param extraConfig this table's extra configuration properties
* @param owner this table's owner
+ * @param comment this table's comment
*/
KuduTable(AsyncKuduClient client, String name, String tableId,
Schema schema, PartitionSchema partitionSchema, int numReplicas,
- Map<String, String> extraConfig, String owner) {
+ Map<String, String> extraConfig, String owner, String comment) {
this.schema = schema;
this.partitionSchema = partitionSchema;
this.client = client;
@@ -74,6 +76,7 @@ public class KuduTable {
this.numReplicas = numReplicas;
this.extraConfig = extraConfig;
this.owner = owner;
+ this.comment = comment;
}
/**
@@ -139,6 +142,15 @@ public class KuduTable {
}
/**
+ * Get this table's comment.
+ *
+ * @return this table's comment.
+ */
+ public String getComment() {
+ return comment;
+ }
+
+ /**
* Get the async client that created this instance.
* @return an async kudu client
*/
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java b/java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
index 6613b84..4b4b1c7 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
@@ -289,6 +289,7 @@ public class SchemaGenerator {
}
options.setOwner("random-" + random.nextInt(1000000));
+ options.setComment("Table schema generated by SchemaGenerator");
return options;
}
diff --git a/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java b/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
index 4df496f..3774284 100644
--- a/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
+++ b/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
@@ -590,4 +590,23 @@ public class TestAlterTable {
table = client.openTable(table.getName());
assertEquals(newOwner, table.getOwner());
}
+
+ @Test
+ public void testAlterChangeComment() throws Exception {
+ String originalComment = "original comment";
+ ArrayList<ColumnSchema> columns = new ArrayList<>(1);
+ columns.add(new ColumnSchema.ColumnSchemaBuilder("key", Type.INT32).key(true).build());
+ columns.add(new ColumnSchema.ColumnSchemaBuilder("val", Type.INT32).build());
+ Schema schema = new Schema(columns);
+ CreateTableOptions createOptions = new CreateTableOptions()
+ .setRangePartitionColumns(ImmutableList.of("key"))
+ .setComment(originalComment);
+ KuduTable table = client.createTable(tableName, schema, createOptions);
+ assertEquals(originalComment, table.getComment());
+
+ String newComment = "new comment";
+ client.alterTable(table.getName(), new AlterTableOptions().setComment(newComment));
+ table = client.openTable(table.getName());
+ assertEquals(newComment, table.getComment());
+ }
}
diff --git a/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java b/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
index 3c9a4fe..d6fbd0f 100644
--- a/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
+++ b/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
@@ -177,7 +177,7 @@ public class TestAsyncKuduClient {
// Test that a tablet full of unreachable replicas won't make us retry.
try {
KuduTable badTable = new KuduTable(asyncClient, "Invalid table name",
- "Invalid table ID", null, null, 3, null, null);
+ "Invalid table ID", null, null, 3, null, null, null);
asyncClient.discoverTablets(badTable, null, requestBatchSize,
tabletLocations, tsInfos, 1000);
fail("This should have failed quickly");
diff --git a/java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java b/java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
index dae90d4..91d5f76 100644
--- a/java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
+++ b/java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
@@ -118,7 +118,7 @@ public class TestKeyEncoding {
Schema schemaOneString =
buildSchema(new ColumnSchema.ColumnSchemaBuilder("key", Type.STRING).key(true));
KuduTable table = new KuduTable(null, "one", "one", schemaOneString,
- defaultPartitionSchema(schemaOneString), 3, null, null);
+ defaultPartitionSchema(schemaOneString), 3, null, null, null);
Insert oneKeyInsert = new Insert(table);
PartialRow row = oneKeyInsert.getRow();
row.addString("key", "foo");
@@ -128,7 +128,7 @@ public class TestKeyEncoding {
new ColumnSchema.ColumnSchemaBuilder("key", Type.STRING).key(true),
new ColumnSchema.ColumnSchemaBuilder("key2", Type.STRING).key(true));
KuduTable table2 = new KuduTable(null, "two", "two", schemaTwoString,
- defaultPartitionSchema(schemaTwoString), 3, null, null);
+ defaultPartitionSchema(schemaTwoString), 3, null, null, null);
Insert twoKeyInsert = new Insert(table2);
row = twoKeyInsert.getRow();
row.addString("key", "foo");
@@ -147,7 +147,7 @@ public class TestKeyEncoding {
new ColumnSchema.ColumnSchemaBuilder("key2", Type.STRING).key(true));
PartitionSchema partitionSchemaIntString = defaultPartitionSchema(schemaIntString);
KuduTable table3 = new KuduTable(null, "three", "three",
- schemaIntString, partitionSchemaIntString, 3, null, null);
+ schemaIntString, partitionSchemaIntString, 3, null, null, null);
Insert small = new Insert(table3);
row = small.getRow();
row.addInt("key", 20);
[kudu] 02/02: [python] KUDU-3164: Add Python table comment support
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
granthenke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 04d3ba7a0a60817d8142b70a222a9ed3b6724f6f
Author: Grant Henke <gr...@apache.org>
AuthorDate: Thu May 6 14:26:47 2021 -0500
[python] KUDU-3164: Add Python table comment support
This patch adds table comment support to the Python client.
Change-Id: I533572fc5157a6d3beb6d1005d9f351f674c3340
Reviewed-on: http://gerrit.cloudera.org:8080/17405
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
---
python/kudu/client.pyx | 24 +++++++++++++++++++++++-
python/kudu/libkudu_client.pxd | 3 +++
python/kudu/tests/test_client.py | 31 +++++++++++++++++++++++++++++++
3 files changed, 57 insertions(+), 1 deletion(-)
diff --git a/python/kudu/client.pyx b/python/kudu/client.pyx
index 777ee99..f26fafc 100644
--- a/python/kudu/client.pyx
+++ b/python/kudu/client.pyx
@@ -363,7 +363,7 @@ cdef class Client:
return from_hybridtime(self.cp.GetLatestObservedTimestamp())
def create_table(self, table_name, Schema schema, partitioning,
- n_replicas=None, owner=None):
+ n_replicas=None, owner=None, comment=None):
"""
Creates a new Kudu table from the passed Schema and options.
@@ -388,6 +388,8 @@ cdef class Client:
c.num_replicas(n_replicas)
if owner:
c.set_owner(tobytes(owner))
+ if comment:
+ c.set_comment(tobytes(comment))
s = c.Create()
check_status(s)
finally:
@@ -840,6 +842,11 @@ cdef class Table:
def __get__(self):
return frombytes(self.ptr().owner())
+ property comment:
+ """Comment on the table."""
+ def __get__(self):
+ return frombytes(self.ptr().comment())
+
def rename(self, new_name):
raise NotImplementedError
@@ -3256,6 +3263,21 @@ cdef class TableAlterer:
self._alterer.SetOwner(tobytes(new_owner))
return self
+ def set_comment(self, new_comment):
+ """
+ Set the comment on the table.
+
+ Parameters
+ ----------
+ new_comment : string
+
+ Returns
+ -------
+ self : TableAlterer
+ """
+ self._alterer.SetComment(tobytes(new_comment))
+ return self
+
def alter(self):
"""
Alter table. Returns a new table object upon completion of the alter.
diff --git a/python/kudu/libkudu_client.pxd b/python/kudu/libkudu_client.pxd
index dc3b782..aa91cd7 100644
--- a/python/kudu/libkudu_client.pxd
+++ b/python/kudu/libkudu_client.pxd
@@ -605,6 +605,7 @@ cdef extern from "kudu/client/client.h" namespace "kudu::client" nogil:
KuduTableCreator& num_replicas(int n_replicas)
KuduTableCreator& wait(c_bool wait)
KuduTableCreator& set_owner(const string& owner)
+ KuduTableCreator& set_comment(const string& comment)
Status Create()
@@ -622,6 +623,7 @@ cdef extern from "kudu/client/client.h" namespace "kudu::client" nogil:
RangePartitionBound lower_bound_type,
RangePartitionBound upper_bound_type)
KuduTableAlterer& SetOwner(const string& new_owner)
+ KuduTableAlterer& SetComment(const string& new_comment)
KuduTableAlterer& wait(c_bool wait)
@@ -634,6 +636,7 @@ cdef extern from "kudu/client/client.h" namespace "kudu::client" nogil:
string& name()
string& id()
string& owner()
+ string& comment()
KuduSchema& schema()
int num_replicas()
diff --git a/python/kudu/tests/test_client.py b/python/kudu/tests/test_client.py
index b7f4ffe..6305285 100755
--- a/python/kudu/tests/test_client.py
+++ b/python/kudu/tests/test_client.py
@@ -170,6 +170,22 @@ class TestClient(KuduTestBase, unittest.TestCase):
except:
pass
+ def test_create_table_with_different_comment(self):
+ name = 'table_with_different_comment'
+ try:
+ self.client.create_table(
+ name, self.schema,
+ partitioning=Partitioning().add_hash_partitions(['key'], 2),
+ comment='new comment')
+
+ self.assertEqual('new comment', self.client.table(name).comment)
+
+ finally:
+ try:
+ self.client.delete_table(name)
+ except:
+ pass
+
def test_insert_nonexistent_field(self):
table = self.client.table(self.ex_table)
op = table.new_insert()
@@ -390,6 +406,21 @@ class TestClient(KuduTestBase, unittest.TestCase):
finally:
self.client.delete_table(name)
+ def test_alter_table_change_comment(self):
+ name = 'alter-comment'
+ try:
+ self.client.create_table(name,
+ self.schema,
+ self.partitioning)
+ table = self.client.table(name)
+ alterer = self.client.new_table_alterer(table)
+ table = alterer.set_comment('change comment').alter()
+ self.assertEqual('change comment', self.client.table(name).comment)
+ with self.assertRaises(TypeError):
+ alterer.set_comment(None).alter()
+ finally:
+ self.client.delete_table(name)
+
def test_alter_column(self):
try:
self.client.create_table('alter-column',