[GitHub] [couchdb] nickva commented on a change in pull request #3880: Remove ERL_OPTS

[GitBox <gi...@apache.org>]

nickva commented on a change in pull request #3880:
URL: https://github.com/apache/couchdb/pull/3880#discussion_r771634068



##########
File path: rebar.config.script
##########
@@ -186,18 +186,13 @@ MakeDep = fun
         {AppName, ".*", {git, Url, Version}, Options}
 end.
 
-ErlOpts = case os:getenv("ERL_OPTS") of
-    false -> [];
-    Opts -> [list_to_atom(O) || O <- string:tokens(Opts, ",")]
-end.
-
 AddConfig = [
     {require_otp_vsn, "21|22|23|24"},
     {deps_dir, "src"},
     {deps, lists:map(MakeDep, DepDescs ++ OptionalDeps)},
     {sub_dirs, SubDirs},
     {lib_dirs, ["src"]},
-    {erl_opts, [{i, "../"} | ErlOpts]},
+    {erl_opts, [{i, "../"} | compile:env_compiler_options()]},

Review comment:
       Since compiler consults those automatically, we probably don't have to set it at all?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org