You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Tomek Rękawek (JIRA)" <ji...@apache.org> on 2016/04/21 13:19:25 UTC

[jira] [Created] (OAK-4266) NodeDocumentCache#get method should be synchronized

Tomek Rękawek created OAK-4266:
----------------------------------

             Summary: NodeDocumentCache#get method should be synchronized
                 Key: OAK-4266
                 URL: https://issues.apache.org/jira/browse/OAK-4266
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: documentmk
            Reporter: Tomek Rękawek
             Fix For: 1.6


The {{NodeDocumentCache#get(String key, Callable)}} method may modify the cache if there's no value for the given {{key}}. Therefore, it should be synchronized using {{NodeDocumentLocks}}, as all the methods modifying the cache are.

Right now, the {{get()}} method is invoked in 3 different places within the Oak codebase. All of them are critical sections anyway, so this modification won't result in a performance decrease.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)