You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/06/08 02:47:15 UTC

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment 

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15814


Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................

IMPALA-9709: Remove Impala-lzo from the development environment

This removes Impala-lzo from the Impala development environment.
Impala-lzo is not built as part of the Impala build. LZO is no
longer loaded a plugin. LZO tables are not loaded during dataload,
and LZO is no longer tested.

This removes some obsolete scan APIs that were only used by Impala-lzo.
With this commit, Impala-lzo would require code changes to build
against Impala.

The plugin infrastructure is not removed, and this leaves some
LZO support code in place. If someone were to decide to revive
Impala-lzo, they would still be able to load it as a plugin
and get the same functionality as before. This plugin support
may be removed later.

Testing:
 - Dryrun of GVO
 - Modified TestPartitionMetadataUncompressedTextOnly's
   test_unsupported_text_compression() to add LZO case

Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
---
M CMakeLists.txt
M be/src/exec/hdfs-plugin-text-scanner.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M bin/bootstrap_system.sh
M bin/clean.sh
M bin/impala-config.sh
M bin/set-ld-library-path.sh
M bin/start-impala-cluster.py
M buildall.sh
M docker/entrypoint.sh
M docker/impala_base/Dockerfile
M docker/test-with-docker.py
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsCompression.java
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
D testdata/bad_text_lzo/bad_text.lzo
D testdata/bad_text_lzo/bad_text.lzo.index
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/generate-test-vectors.py
M testdata/bin/load_nested.py
D testdata/bin/lzo_indexer.sh
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/joins-hdfs-num-rows-est-enabled.test
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-query/functional-query_dimensions.csv
M testdata/workloads/functional-query/functional-query_exhaustive.csv
M testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
D testdata/workloads/functional-query/queries/QueryTest/disable-lzo-plugin.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
M testdata/workloads/functional-query/queries/QueryTest/unsupported-compression-partitions.test
M testdata/workloads/perf-regression/perf-regression_dimensions.csv
M testdata/workloads/perf-regression/perf-regression_exhaustive.csv
M testdata/workloads/perf-regression/perf-regression_pairwise.csv
M testdata/workloads/targeted-perf/targeted-perf_dimensions.csv
M testdata/workloads/targeted-perf/targeted-perf_exhaustive.csv
M testdata/workloads/targeted-perf/targeted-perf_pairwise.csv
M testdata/workloads/targeted-stress/targeted-stress_dimensions.csv
M testdata/workloads/targeted-stress/targeted-stress_exhaustive.csv
M testdata/workloads/targeted-stress/targeted-stress_pairwise.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_dimensions.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_exhaustive.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_pairwise.csv
M testdata/workloads/tpcds/tpcds_dimensions.csv
M testdata/workloads/tpcds/tpcds_exhaustive.csv
M testdata/workloads/tpcds/tpcds_pairwise.csv
M testdata/workloads/tpch/tpch_dimensions.csv
M testdata/workloads/tpch/tpch_exhaustive.csv
M testdata/workloads/tpch/tpch_pairwise.csv
M tests/common/test_dimensions.py
M tests/custom_cluster/test_hive_text_codec_interop.py
D tests/custom_cluster/test_scanner_plugin.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_scanners_fuzz.py
62 files changed, 85 insertions(+), 333 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/15814/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 5:

(2 comments)

Looks good!
just a few more updates left as follows:

codec.cc => update the message in NO_LZO_MSG
HdfsScanNode.java => update VALID_LEGACY_FORMATS
HdfsTableSink.java => update SUPPORTED_FILE_FORMATS

http://gerrit.cloudera.org:8080/#/c/15814/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15814/5//COMMIT_MSG@11
PS5, Line 11: longer loaded a plugin. LZO tables are not loaded during dataload,
nit: as a


http://gerrit.cloudera.org:8080/#/c/15814/5/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
File testdata/workloads/functional-query/queries/QueryTest/show-create-table.test:

http://gerrit.cloudera.org:8080/#/c/15814/5/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test@a381
PS5, Line 381: 
nit: i think this test might have been put in to verify INPUTFORMAT and OUTPUTFORMAT syntax. We can probably use alltypes_no_coldef (avro) here instead



-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jun 2020 20:51:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 7: Verified+1

Top of stack passed GVO, carrying +1 down


-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 23:41:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6321/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 06:03:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15814

to look at the new patch set (#7).

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................

IMPALA-9709: Remove Impala-lzo from the development environment

This removes Impala-lzo from the Impala development environment.
Impala-lzo is not built as part of the Impala build. The LZO plugin
is no longer loaded. LZO tables are not loaded during dataload,
and LZO is no longer tested.

This removes some obsolete scan APIs that were only used by Impala-lzo.
With this commit, Impala-lzo would require code changes to build
against Impala.

The plugin infrastructure is not removed, and this leaves some
LZO support code in place. If someone were to decide to revive
Impala-lzo, they would still be able to load it as a plugin
and get the same functionality as before. This plugin support
may be removed later.

Testing:
 - Dryrun of GVO
 - Modified TestPartitionMetadataUncompressedTextOnly's
   test_unsupported_text_compression() to add LZO case

Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
---
M CMakeLists.txt
M be/src/exec/hdfs-plugin-text-scanner.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/util/codec.cc
M bin/bootstrap_system.sh
M bin/clean.sh
M bin/impala-config.sh
M bin/set-ld-library-path.sh
M bin/start-impala-cluster.py
M buildall.sh
M docker/entrypoint.sh
M docker/impala_base/Dockerfile
M docker/test-with-docker.py
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsCompression.java
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
D testdata/bad_text_lzo/bad_text.lzo
D testdata/bad_text_lzo/bad_text.lzo.index
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/generate-test-vectors.py
M testdata/bin/load_nested.py
D testdata/bin/lzo_indexer.sh
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/joins-hdfs-num-rows-est-enabled.test
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-query/functional-query_dimensions.csv
M testdata/workloads/functional-query/functional-query_exhaustive.csv
M testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
D testdata/workloads/functional-query/queries/QueryTest/disable-lzo-plugin.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
M testdata/workloads/functional-query/queries/QueryTest/unsupported-compression-partitions.test
M testdata/workloads/perf-regression/perf-regression_dimensions.csv
M testdata/workloads/perf-regression/perf-regression_exhaustive.csv
M testdata/workloads/perf-regression/perf-regression_pairwise.csv
M testdata/workloads/targeted-perf/targeted-perf_dimensions.csv
M testdata/workloads/targeted-perf/targeted-perf_exhaustive.csv
M testdata/workloads/targeted-perf/targeted-perf_pairwise.csv
M testdata/workloads/targeted-stress/targeted-stress_dimensions.csv
M testdata/workloads/targeted-stress/targeted-stress_exhaustive.csv
M testdata/workloads/targeted-stress/targeted-stress_pairwise.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_dimensions.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_exhaustive.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_pairwise.csv
M testdata/workloads/tpcds/tpcds_dimensions.csv
M testdata/workloads/tpcds/tpcds_exhaustive.csv
M testdata/workloads/tpcds/tpcds_pairwise.csv
M testdata/workloads/tpch/tpch_dimensions.csv
M testdata/workloads/tpch/tpch_exhaustive.csv
M testdata/workloads/tpch/tpch_pairwise.csv
M tests/common/test_dimensions.py
M tests/custom_cluster/test_hive_text_codec_interop.py
D tests/custom_cluster/test_scanner_plugin.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_scanners_fuzz.py
65 files changed, 88 insertions(+), 346 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/15814/7
-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 5:

I took a quick look and didn't have any concerns in addition to bikram's


-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jun 2020 22:01:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15814

to look at the new patch set (#6).

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................

IMPALA-9709: Remove Impala-lzo from the development environment

This removes Impala-lzo from the Impala development environment.
Impala-lzo is not built as part of the Impala build. The LZO plugin
is no longer loaded. LZO tables are not loaded during dataload,
and LZO is no longer tested.

This removes some obsolete scan APIs that were only used by Impala-lzo.
With this commit, Impala-lzo would require code changes to build
against Impala.

The plugin infrastructure is not removed, and this leaves some
LZO support code in place. If someone were to decide to revive
Impala-lzo, they would still be able to load it as a plugin
and get the same functionality as before. This plugin support
may be removed later.

Testing:
 - Dryrun of GVO
 - Modified TestPartitionMetadataUncompressedTextOnly's
   test_unsupported_text_compression() to add LZO case

Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
---
M CMakeLists.txt
M be/src/exec/hdfs-plugin-text-scanner.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/util/codec.cc
M bin/bootstrap_system.sh
M bin/clean.sh
M bin/impala-config.sh
M bin/set-ld-library-path.sh
M bin/start-impala-cluster.py
M buildall.sh
M docker/entrypoint.sh
M docker/impala_base/Dockerfile
M docker/test-with-docker.py
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsCompression.java
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
D testdata/bad_text_lzo/bad_text.lzo
D testdata/bad_text_lzo/bad_text.lzo.index
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/generate-test-vectors.py
M testdata/bin/load_nested.py
D testdata/bin/lzo_indexer.sh
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/joins-hdfs-num-rows-est-enabled.test
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-query/functional-query_dimensions.csv
M testdata/workloads/functional-query/functional-query_exhaustive.csv
M testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
D testdata/workloads/functional-query/queries/QueryTest/disable-lzo-plugin.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
M testdata/workloads/functional-query/queries/QueryTest/unsupported-compression-partitions.test
M testdata/workloads/perf-regression/perf-regression_dimensions.csv
M testdata/workloads/perf-regression/perf-regression_exhaustive.csv
M testdata/workloads/perf-regression/perf-regression_pairwise.csv
M testdata/workloads/targeted-perf/targeted-perf_dimensions.csv
M testdata/workloads/targeted-perf/targeted-perf_exhaustive.csv
M testdata/workloads/targeted-perf/targeted-perf_pairwise.csv
M testdata/workloads/targeted-stress/targeted-stress_dimensions.csv
M testdata/workloads/targeted-stress/targeted-stress_exhaustive.csv
M testdata/workloads/targeted-stress/targeted-stress_pairwise.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_dimensions.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_exhaustive.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_pairwise.csv
M testdata/workloads/tpcds/tpcds_dimensions.csv
M testdata/workloads/tpcds/tpcds_exhaustive.csv
M testdata/workloads/tpcds/tpcds_pairwise.csv
M testdata/workloads/tpch/tpch_dimensions.csv
M testdata/workloads/tpch/tpch_exhaustive.csv
M testdata/workloads/tpch/tpch_pairwise.csv
M tests/common/test_dimensions.py
M tests/custom_cluster/test_hive_text_codec_interop.py
D tests/custom_cluster/test_scanner_plugin.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_scanners_fuzz.py
65 files changed, 88 insertions(+), 346 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/15814/6
-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6234/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 03:48:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15814

to look at the new patch set (#5).

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................

IMPALA-9709: Remove Impala-lzo from the development environment

This removes Impala-lzo from the Impala development environment.
Impala-lzo is not built as part of the Impala build. LZO is no
longer loaded a plugin. LZO tables are not loaded during dataload,
and LZO is no longer tested.

This removes some obsolete scan APIs that were only used by Impala-lzo.
With this commit, Impala-lzo would require code changes to build
against Impala.

The plugin infrastructure is not removed, and this leaves some
LZO support code in place. If someone were to decide to revive
Impala-lzo, they would still be able to load it as a plugin
and get the same functionality as before. This plugin support
may be removed later.

Testing:
 - Dryrun of GVO
 - Modified TestPartitionMetadataUncompressedTextOnly's
   test_unsupported_text_compression() to add LZO case

Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
---
M CMakeLists.txt
M be/src/exec/hdfs-plugin-text-scanner.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M bin/bootstrap_system.sh
M bin/clean.sh
M bin/impala-config.sh
M bin/set-ld-library-path.sh
M bin/start-impala-cluster.py
M buildall.sh
M docker/entrypoint.sh
M docker/impala_base/Dockerfile
M docker/test-with-docker.py
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsCompression.java
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
D testdata/bad_text_lzo/bad_text.lzo
D testdata/bad_text_lzo/bad_text.lzo.index
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/generate-test-vectors.py
M testdata/bin/load_nested.py
D testdata/bin/lzo_indexer.sh
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/joins-hdfs-num-rows-est-enabled.test
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-query/functional-query_dimensions.csv
M testdata/workloads/functional-query/functional-query_exhaustive.csv
M testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
D testdata/workloads/functional-query/queries/QueryTest/disable-lzo-plugin.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
M testdata/workloads/functional-query/queries/QueryTest/unsupported-compression-partitions.test
M testdata/workloads/perf-regression/perf-regression_dimensions.csv
M testdata/workloads/perf-regression/perf-regression_exhaustive.csv
M testdata/workloads/perf-regression/perf-regression_pairwise.csv
M testdata/workloads/targeted-perf/targeted-perf_dimensions.csv
M testdata/workloads/targeted-perf/targeted-perf_exhaustive.csv
M testdata/workloads/targeted-perf/targeted-perf_pairwise.csv
M testdata/workloads/targeted-stress/targeted-stress_dimensions.csv
M testdata/workloads/targeted-stress/targeted-stress_exhaustive.csv
M testdata/workloads/targeted-stress/targeted-stress_pairwise.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_dimensions.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_exhaustive.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_pairwise.csv
M testdata/workloads/tpcds/tpcds_dimensions.csv
M testdata/workloads/tpcds/tpcds_exhaustive.csv
M testdata/workloads/tpcds/tpcds_pairwise.csv
M testdata/workloads/tpch/tpch_dimensions.csv
M testdata/workloads/tpch/tpch_exhaustive.csv
M testdata/workloads/tpch/tpch_pairwise.csv
M tests/common/test_dimensions.py
M tests/custom_cluster/test_hive_text_codec_interop.py
D tests/custom_cluster/test_scanner_plugin.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_scanners_fuzz.py
62 files changed, 85 insertions(+), 333 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/15814/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 19:07:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6232/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 03:32:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 5:

(2 comments)

> (2 comments)
 > 
 > Looks good!
 > just a few more updates left as follows:
 > 
 > codec.cc => update the message in NO_LZO_MSG
 > HdfsScanNode.java => update VALID_LEGACY_FORMATS
 > HdfsTableSink.java => update SUPPORTED_FILE_FORMATS

Sorry to take so long getting back to this.

For NO_LZO_MSG, I updated it to say that LZO is processed by an optional plugin. Is that what you had in mind?

I removed LZO_TEXT from VALID_LEGACY_FORMATS and SUPPORTED_FILE_FORMATS. It turns out that LZO_TEXT was never actually being used on those codepaths. Instead, LZO tables use TEXT and the HdfsFileFormat. We could have removed those locations before this change. I added a comment in the declaration of LZO_TEXT to note that it isn't used like the other HdfsFileFormats.

http://gerrit.cloudera.org:8080/#/c/15814/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15814/5//COMMIT_MSG@11
PS5, Line 11: longer loaded a plugin. LZO tables are not loaded during dataload,
> nit: as a
Reworked the sentence.


http://gerrit.cloudera.org:8080/#/c/15814/5/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
File testdata/workloads/functional-query/queries/QueryTest/show-create-table.test:

http://gerrit.cloudera.org:8080/#/c/15814/5/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test@a381
PS5, Line 381: 
> nit: i think this test might have been put in to verify INPUTFORMAT and OUT
Good point, this test was specific to LZO. Impala doesn't support INPUTFORMAT/OUTPUTFORMAT, so these were only ever outputted for LZO so that the statement would work in Hive. We never use INPUTFORMAT/OUTPUTFORMAT for anything else.

It looks like we already have coverage for show create table on text, so I'm just going to remove this test.



-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 05:25:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15814/4/tests/metadata/test_partition_metadata.py
File tests/metadata/test_partition_metadata.py:

http://gerrit.cloudera.org:8080/#/c/15814/4/tests/metadata/test_partition_metadata.py@215
PS4, Line 215: F
> flake8: E122 continuation line missing indentation or outdented
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 03:35:06 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................

IMPALA-9709: Remove Impala-lzo from the development environment

This removes Impala-lzo from the Impala development environment.
Impala-lzo is not built as part of the Impala build. The LZO plugin
is no longer loaded. LZO tables are not loaded during dataload,
and LZO is no longer tested.

This removes some obsolete scan APIs that were only used by Impala-lzo.
With this commit, Impala-lzo would require code changes to build
against Impala.

The plugin infrastructure is not removed, and this leaves some
LZO support code in place. If someone were to decide to revive
Impala-lzo, they would still be able to load it as a plugin
and get the same functionality as before. This plugin support
may be removed later.

Testing:
 - Dryrun of GVO
 - Modified TestPartitionMetadataUncompressedTextOnly's
   test_unsupported_text_compression() to add LZO case

Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Reviewed-on: http://gerrit.cloudera.org:8080/15814
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M CMakeLists.txt
M be/src/exec/hdfs-plugin-text-scanner.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/util/codec.cc
M bin/bootstrap_system.sh
M bin/clean.sh
M bin/impala-config.sh
M bin/set-ld-library-path.sh
M bin/start-impala-cluster.py
M buildall.sh
M docker/entrypoint.sh
M docker/impala_base/Dockerfile
M docker/test-with-docker.py
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsCompression.java
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
D testdata/bad_text_lzo/bad_text.lzo
D testdata/bad_text_lzo/bad_text.lzo.index
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/generate-test-vectors.py
M testdata/bin/load_nested.py
D testdata/bin/lzo_indexer.sh
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-planner/queries/PlannerTest/joins-hdfs-num-rows-est-enabled.test
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-query/functional-query_dimensions.csv
M testdata/workloads/functional-query/functional-query_exhaustive.csv
M testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
D testdata/workloads/functional-query/queries/QueryTest/disable-lzo-plugin.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
M testdata/workloads/functional-query/queries/QueryTest/unsupported-compression-partitions.test
M testdata/workloads/perf-regression/perf-regression_dimensions.csv
M testdata/workloads/perf-regression/perf-regression_exhaustive.csv
M testdata/workloads/perf-regression/perf-regression_pairwise.csv
M testdata/workloads/targeted-perf/targeted-perf_dimensions.csv
M testdata/workloads/targeted-perf/targeted-perf_exhaustive.csv
M testdata/workloads/targeted-perf/targeted-perf_pairwise.csv
M testdata/workloads/targeted-stress/targeted-stress_dimensions.csv
M testdata/workloads/targeted-stress/targeted-stress_exhaustive.csv
M testdata/workloads/targeted-stress/targeted-stress_pairwise.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_dimensions.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_exhaustive.csv
M testdata/workloads/tpcds-unmodified/tpcds-unmodified_pairwise.csv
M testdata/workloads/tpcds/tpcds_dimensions.csv
M testdata/workloads/tpcds/tpcds_exhaustive.csv
M testdata/workloads/tpcds/tpcds_pairwise.csv
M testdata/workloads/tpch/tpch_dimensions.csv
M testdata/workloads/tpch/tpch_exhaustive.csv
M testdata/workloads/tpch/tpch_pairwise.csv
M tests/common/test_dimensions.py
M tests/custom_cluster/test_hive_text_codec_interop.py
D tests/custom_cluster/test_scanner_plugin.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_scanners_fuzz.py
65 files changed, 88 insertions(+), 346 deletions(-)

Approvals:
  Bikramjeet Vig: Looks good to me, approved
  Joe McDonnell: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6320/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 06:12:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 7:

Rebased to latest master


-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 05:28:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 )

Change subject: IMPALA-9709: Remove Impala-lzo from the development environment
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15814/4/tests/metadata/test_partition_metadata.py
File tests/metadata/test_partition_metadata.py:

http://gerrit.cloudera.org:8080/#/c/15814/4/tests/metadata/test_partition_metadata.py@215
PS4, Line 215: F
flake8: E122 continuation line missing indentation or outdented



-- 
To view, visit http://gerrit.cloudera.org:8080/15814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a4f12247d8872b7e14c9feb4b2c58cfd60d4c0e
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 02:48:00 +0000
Gerrit-HasComments: Yes