You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by "Ran Tao (Jira)" <ji...@apache.org> on 2023/07/09 06:56:00 UTC

[jira] [Created] (CALCITE-5823) Remove commons-collections dependency from innodb

Ran Tao created CALCITE-5823:
--------------------------------

             Summary: Remove commons-collections dependency from innodb
                 Key: CALCITE-5823
                 URL: https://issues.apache.org/jira/browse/CALCITE-5823
             Project: Calcite
          Issue Type: Improvement
          Components: innodb-adapter
    Affects Versions: 1.34.0
            Reporter: Ran Tao
            Assignee: Ran Tao
             Fix For: 1.35.0


Currently,  \{CollectionsUtils} is only used in a few places in the InnoDb adapter, and the only methods used are \{isEmpty}} and \{isNotEmpty}. 

The only difference between \{CollectionUtils.isEmpty} and \{list.isEmpty} is the behavior if \{list} is null. Modern coding practices would ensure that \{list} is not null unless specified in its type.

So we can safely remove it to avoid using an entire library just for the sake of using \{isEmpty}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)