[GitHub] sanha commented on a change in pull request #190: [NEMO-328] Refactor IRDAG

[GitBox <gi...@apache.org>]

sanha commented on a change in pull request #190: [NEMO-328] Refactor IRDAG
URL: https://github.com/apache/incubator-nemo/pull/190#discussion_r250465045
 
 

 ##########
 File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/reshaping/SkewReshapingPass.java
 ##########
 @@ -47,17 +41,13 @@
 
 /**
  * Pass to reshape the IR DAG for skew handling.
- *
- * This pass inserts vertices to perform two-step dynamic optimization for skew handling.
- * 1) Task-level statistic collection is done via vertex with {@link MetricCollectTransform}
- * 2) Stage-level statistic aggregation is done via vertex with {@link AggregateMetricTransform}
- * inserted before shuffle edges.
+ * We insert a {@link MessageBarrierVertex for each shuffle edge}
 
 Review comment:
   We **must** optimize multiple shuffle edges at once if a vertex receives many shuffle edges. Please check [327](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-327?filter=allopenissues).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services