You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/25 23:36:07 UTC
[GitHub] [incubator-superset] rusackas commented on a change in pull request
#8633: Font styling consolidation
rusackas commented on a change in pull request #8633: Font styling consolidation
URL: https://github.com/apache/incubator-superset/pull/8633#discussion_r350477784
##########
File path: superset/assets/src/CRUD/crud.less
##########
@@ -24,24 +26,24 @@
padding: 10px;
}
.control-label {
- font-weight: bold;
- font-size: 16px;
+ font-weight: @font-weight-bold;
+ font-size: @font-size-l;
Review comment:
Thought it might be better to be systematic, since the sizes range is `xxs`, `xs`, `s`, `m`, `l`, `xl`, `xxl`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org