You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/11 09:11:13 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #1512: [Enhancement] Use the {} tag to inject dynamic content into the string [WatchFileTask]

Alonexc opened a new issue, #1512:
URL: https://github.com/apache/incubator-eventmesh/issues/1512

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/195039895-abc5f559-2ae3-439a-bdb2-cddf0eae5513.png)
   located at: org/apache/eventmesh/common/file/WatchFileTask.java line 93
   This method uses the SLF4J or Log4j2 logger to log a String where the first (format) string is created using concatenation. You should inject dynamic content into the string using the {} tag so that String construction is delayed until the actual logging string is needed. If the logging level is high enough that this logging statement is not used, then the appended content will never be executed.
   
   ### Describe the solution you'd like
   
   It is recommended to use the {} tag to inject dynamic content into the string.
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] mroccyen commented on issue #1512: [Enhancement] Use the {} tag to inject dynamic content into the string [WatchFileTask]

Posted by GitBox <gi...@apache.org>.
mroccyen commented on issue #1512:
URL: https://github.com/apache/incubator-eventmesh/issues/1512#issuecomment-1274476644

   i will try my best to do it,please assign to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 closed issue #1512: [Enhancement] Use the {} tag to inject dynamic content into the string [WatchFileTask]

Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #1512: [Enhancement] Use the {} tag to inject dynamic content into the string [WatchFileTask]
URL: https://github.com/apache/incubator-eventmesh/issues/1512


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org