You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/17 20:42:09 UTC

[GitHub] [arrow] nealrichardson opened a new pull request, #14441: ARROW-18080: [C++] Remove gcc <= 4.9 workarounds

nealrichardson opened a new pull request, #14441:
URL: https://github.com/apache/arrow/pull/14441

   This is most of them I could find. There's another one in `python/pyarrow/src/arrow/python/datetime.cc` to remove but it's more involved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou commented on a diff in pull request #14441: ARROW-18080: [C++] Remove gcc <= 4.9 workarounds

Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #14441:
URL: https://github.com/apache/arrow/pull/14441#discussion_r997513593


##########
ci/conan/all/conanfile.py:
##########
@@ -266,10 +266,7 @@ def _with_boost(self, required=False):
             if self.options.gandiva:
                 return True
             version = tools.Version(self.version)
-            if version.major == "1":
-                if self._parquet() and self.settings.compiler == "gcc" and self.settings.compiler.version < tools.Version("4.9"):
-                    return True
-            elif version.major >= "2":
+            if version.major >= "2":

Review Comment:
   Could you revert all changes in this file?
   A Conan package supports multiple versions in the same file. So we still need to support old versions in this file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou commented on pull request #14441: ARROW-18080: [C++] Remove gcc <= 4.9 workarounds

Posted by GitBox <gi...@apache.org>.
kou commented on PR #14441:
URL: https://github.com/apache/arrow/pull/14441#issuecomment-1281542138

   Could you also fix a CMake lint failure?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] nealrichardson commented on pull request #14441: ARROW-18080: [C++] Remove gcc <= 4.9 workarounds

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #14441:
URL: https://github.com/apache/arrow/pull/14441#issuecomment-1282946105

   Reverted and formatted, ready to merge when CI passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou merged pull request #14441: ARROW-18080: [C++] Remove gcc <= 4.9 workarounds

Posted by GitBox <gi...@apache.org>.
kou merged PR #14441:
URL: https://github.com/apache/arrow/pull/14441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14441: ARROW-18080: [C++] Remove gcc <= 4.9 workarounds

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14441:
URL: https://github.com/apache/arrow/pull/14441#issuecomment-1281470951

   https://issues.apache.org/jira/browse/ARROW-18080


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org