[GitHub] [solr] tomglk commented on pull request #166: SOLR-15450 add PrefetchingFieldValueFeature

[GitBox <gi...@apache.org>]

tomglk commented on pull request #166:
URL: https://github.com/apache/solr/pull/166#issuecomment-855438132


   Hi @cpoerschke ,
   thank you for the quick response. :)
   I addressed your suggestions that were quick to include and will look into the exception-handling / toString()-topics next.
   
   > Not yet looked at the test changes
   
   I am actually quite glad that you didn't, because I just changed the tests quite a lot. 
   Now there is quite a lot of duplicated code if you look at the two prefetching tests in `org.apache.solr.ltr` and the `TestLTROnSolrCloud`.
   I already had a `TestLTROnSolrCloudBase`-class ready to extract the duplicates but was not sure whether to include such a change in this PR because it it would entail a few changes in `TestLTROnSolrCloud` which have nothing to do with the prefetching functionality.
   
   I can make a commit tomorrow(?) only including this change and if you think that it would make the PR too complex we can just revert it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org