You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "suhwan-cheon (via GitHub)" <gi...@apache.org> on 2025/11/22 03:58:51 UTC

Re: [PR] [FLINK-38247] Handle BIGINT UNSIGNED overflow in PreparedStatement [flink-cdc]

suhwan-cheon commented on code in PR #4117:
URL: https://github.com/apache/flink-cdc/pull/4117#discussion_r2551970182


##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlSourceITCase.java:
##########
@@ -1447,6 +1448,98 @@ private boolean hasNextData(final CloseableIterator<?> iterator)
         }
     }
 
+    @Test
+    void testUnsignedBigintPrimaryKeyChunking() throws Exception {
+        customDatabase.createAndInitialize();
+
+        String db = customDatabase.getDatabaseName();
+        String table = "unsigned_bigint_pk";
+        try (MySqlConnection connection = getConnection()) {
+            connection.setAutoCommit(false);
+            String createSql =
+                    String.format(
+                            "CREATE TABLE %s.%s (\n"
+                                    + "  `order_id` BIGINT UNSIGNED NOT NULL,\n"
+                                    + "  `desc` VARCHAR(512) NOT NULL,\n"
+                                    + "  PRIMARY KEY (`order_id`)\n"
+                                    + ") ENGINE=InnoDB DEFAULT CHARSET=utf8;",
+                            StatementUtils.quote(db), StatementUtils.quote(table));
+            // Insert sample data including values near UNSIGNED BIGINT max
+            String insertSql =
+                    String.format(
+                            "INSERT INTO %s.%s (`order_id`, `desc`) VALUES "
+                                    + "(1, 'flink'),(2, 'flink'),(3, 'flink'),(4, 'flink'),(5, 'flink'),"
+                                    + "(6, 'flink'),(7, 'flink'),(8, 'flink'),(9, 'flink'),(10, 'flink'),"
+                                    + "(11, 'flink'),(12, 'flink'),"
+                                    + "(18446744073709551604, 'flink'),(18446744073709551605, 'flink'),"
+                                    + "(18446744073709551606, 'flink'),(18446744073709551607, 'flink'),"
+                                    + "(18446744073709551608, 'flink'),(18446744073709551609, 'flink'),"
+                                    + "(18446744073709551610, 'flink'),(18446744073709551611, 'flink'),"
+                                    + "(18446744073709551612, 'flink'),(18446744073709551613, 'flink'),"
+                                    + "(18446744073709551614, 'flink'),(18446744073709551615, 'flink');",
+                            StatementUtils.quote(db), StatementUtils.quote(table));
+            // Drop if exists to be idempotent across runs, then create and insert
+            connection.execute(
+                    String.format(
+                            "DROP TABLE IF EXISTS %s.%s;",
+                            StatementUtils.quote(db), StatementUtils.quote(table)),
+                    createSql,
+                    insertSql);
+            connection.commit();
+        }
+
+        // Build a source reading only the unsigned_bigint_pk table
+        DataType dataType =
+                DataTypes.ROW(
+                        DataTypes.FIELD("order_id", DataTypes.DECIMAL(20, 0)),
+                        DataTypes.FIELD("desc", DataTypes.STRING()));
+        LogicalType logicalType = TypeConversions.fromDataToLogicalType(dataType);
+        InternalTypeInfo<RowData> typeInfo = InternalTypeInfo.of(logicalType);
+        RowDataDebeziumDeserializeSchema deserializer =
+                RowDataDebeziumDeserializeSchema.newBuilder()
+                        .setPhysicalRowType((RowType) dataType.getLogicalType())
+                        .setResultTypeInfo(typeInfo)
+                        .build();
+
+        MySqlSource<RowData> source =
+                MySqlSource.<RowData>builder()
+                        .hostname(MYSQL_CONTAINER.getHost())
+                        .port(MYSQL_CONTAINER.getDatabasePort())
+                        .username(customDatabase.getUsername())
+                        .password(customDatabase.getPassword())
+                        .serverTimeZone("UTC")
+                        .databaseList(db)
+                        .tableList(db + "." + table)
+                        .deserializer(deserializer)
+                        .startupOptions(StartupOptions.initial())
+                        .chunkKeyColumn(new ObjectPath(db, table), "order_id")

Review Comment:
   Sorry for the late reply.
   I've checked that there's a problem, and I'll try to fix it as soon as possible!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org