You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "laurentgo (via GitHub)" <gi...@apache.org> on 2023/09/26 21:33:40 UTC
[GitHub] [arrow] laurentgo opened a new pull request, #37894: GH-37893: [Java] Move Types.proto in a subfolder
laurentgo opened a new pull request, #37894:
URL: https://github.com/apache/arrow/pull/37894
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project.
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict.
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive.
### Are there any user-facing changes?
No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #37894: GH-37893: [Java] Move Types.proto in a subfolder
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #37894:
URL: https://github.com/apache/arrow/pull/37894#discussion_r1337826952
##########
java/gandiva/CMakeLists.txt:
##########
Review Comment:
It appears you need to lint/format this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] laurentgo commented on pull request #37894: GH-37893: [Java] Move Types.proto in a subfolder
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on PR #37894:
URL: https://github.com/apache/arrow/pull/37894#issuecomment-1738410880
I believe this PR is ready for review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37894: GH-37893: [Java] Move Types.proto in a subfolder
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37894:
URL: https://github.com/apache/arrow/pull/37894#issuecomment-1740089366
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 019d06df56ba3215148465554948a4d93fd9c707.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17236066940) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37894: GH-37893: [Java] Move Types.proto in a subfolder
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37894:
URL: https://github.com/apache/arrow/pull/37894#issuecomment-1736333297
:warning: GitHub issue #37893 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] laurentgo commented on pull request #37894: GH-37893: [Java] Move Types.proto in a subfolder
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on PR #37894:
URL: https://github.com/apache/arrow/pull/37894#issuecomment-1738196695
Looks like I missed a couple of things (I was trying to go directly to PR since I had some build environment issues on my new laptop).
Moving to draft and solving things locally first so that reviewers do not waste too much time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #37894: GH-37893: [Java] Move Types.proto in a subfolder
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #37894:
URL: https://github.com/apache/arrow/pull/37894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] laurentgo commented on a diff in pull request #37894: GH-37893: [Java] Move Types.proto in a subfolder
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on code in PR #37894:
URL: https://github.com/apache/arrow/pull/37894#discussion_r1339217876
##########
java/gandiva/CMakeLists.txt:
##########
Review Comment:
Yes, not easy to figure it out from the output as `cmake-format` does not describe the error, but it should have been addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org