[GitHub] [airflow] Taragolis commented on pull request #24571: Pattern parameter in S3ToSnowflakeOperator

[GitBox <gi...@apache.org>]

Taragolis commented on PR #24571:
URL: https://github.com/apache/airflow/pull/24571#issuecomment-1161363353

   > No expertise to judge whether `pattern` needs special escaping (e.g. what if the pattern contains a `'`?) but `files` is also currently not escaped or validated, so perhaps not? And if there’s a bug, we need to fix them all anyway, and that should happen in a separate PR, not this one.
   
   This is real good question. About `pattern` it should always be escaped by single quote ([doc](https://docs.snowflake.com/en/sql-reference/sql/copy-into-table.html#optional-parameters)) but It unclear what if pattern itself should contain single quote. I agree that at least it should be mention in documentation/docstring.
   
   Never use option `files` for Snowflake, seems like it should also escaped, but documentation unclear about this.
   
   Anyway I will try to check on actual Snowflake during the day different cases


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org