You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by GitBox <gi...@apache.org> on 2017/11/09 22:32:34 UTC

[GitHub] dschoorl opened a new pull request #2: Add Automatic-Module-Name attribute to manifest files

dschoorl opened a new pull request #2: Add Automatic-Module-Name attribute to manifest files
URL: https://github.com/apache/incubator-netbeans-html4j/pull/2
 
 
   This change will provide the user with a predictable automatic module 
   name on a JDK9 module path, that is expected to be unique. This module 
   name is independent of the name of the jar file, even if it is renamed 
   by the user.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Re: [GitHub] dschoorl opened a new pull request #2: Add Automatic-Module-Name attribute to manifest files

Posted by Dave Schoorl <ds...@bkwi.nl>.
@Jaroslav Tulach:
I manually checked some of the manifest files if the new attribute was present and contained the expected value. And the existing tests succeed after running mvn clean package on my system. However, I don't know how to manually run/test the software or what it does (sorry). Maybe you can check this if you deem this necessary?

Best regards,
Dave


> Op 9 november 2017 om 23:32 schreef GitBox <gi...@apache.org>:
> 
> 
> dschoorl opened a new pull request #2: Add Automatic-Module-Name attribute to manifest files
> URL: https://github.com/apache/incubator-netbeans-html4j/pull/2
>  
>  
>    This change will provide the user with a predictable automatic module 
>    name on a JDK9 module path, that is expected to be unique. This module 
>    name is independent of the name of the jar file, even if it is renamed 
>    by the user.
> 
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>  
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
> 
> 
> With regards,
> Apache Git Services