You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Navis (Created) (JIRA)" <ji...@apache.org> on 2012/03/20 09:17:43 UTC
[jira] [Created] (HIVE-2881) Remove redundant key comparing in
SMBMapJoinOperator
Remove redundant key comparing in SMBMapJoinOperator
----------------------------------------------------
Key: HIVE-2881
URL: https://issues.apache.org/jira/browse/HIVE-2881
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Navis
Assignee: Navis
Priority: Minor
Attachments: HIVE-2881.D2379.1.patch
Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2881) Remove redundant key comparing in
SMBMapJoinOperator
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2881:
-----------------------------------
Fix Version/s: 0.9.0
> Remove redundant key comparing in SMBMapJoinOperator
> ----------------------------------------------------
>
> Key: HIVE-2881
> URL: https://issues.apache.org/jira/browse/HIVE-2881
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: HIVE-2881.D2379.1.patch
>
>
> Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2881) Remove redundant key comparing in
SMBMapJoinOperator
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2881:
------------------------------
Attachment: HIVE-2881.D2379.1.patch
navis requested code review of "HIVE-2881 [jira] Remove redundant key comparing in SMBMapJoinOperator".
Reviewers: JIRA
DPAL-988 Remove redundant key comparing in SMBMapJoinOperator
Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2379
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5331/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Remove redundant key comparing in SMBMapJoinOperator
> ----------------------------------------------------
>
> Key: HIVE-2881
> URL: https://issues.apache.org/jira/browse/HIVE-2881
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2881.D2379.1.patch
>
>
> Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2881) Remove redundant key comparing in
SMBMapJoinOperator
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243986#comment-13243986 ]
Phabricator commented on HIVE-2881:
-----------------------------------
njain has accepted the revision "HIVE-2881 [jira] Remove redundant key comparing in SMBMapJoinOperator".
Looks good -
I know this did not have good comments to start with, but it would be great if you can
add more comments for changes like this. It took me a very long time to go over the
code and make sure we are not missing any boundary condition. An example would
have really helped.
REVISION DETAIL
https://reviews.facebook.net/D2379
BRANCH
DPAL-988
> Remove redundant key comparing in SMBMapJoinOperator
> ----------------------------------------------------
>
> Key: HIVE-2881
> URL: https://issues.apache.org/jira/browse/HIVE-2881
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2881.D2379.1.patch
>
>
> Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2881) Remove redundant key comparing in
SMBMapJoinOperator
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244141#comment-13244141 ]
Hudson commented on HIVE-2881:
------------------------------
Integrated in Hive-trunk-h0.21 #1346 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1346/])
HIVE-2881 Remove redundant key comparing in SMBMapJoinOperator
(Navis via namit) (Revision 1308241)
Result = ABORTED
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1308241
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
> Remove redundant key comparing in SMBMapJoinOperator
> ----------------------------------------------------
>
> Key: HIVE-2881
> URL: https://issues.apache.org/jira/browse/HIVE-2881
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2881.D2379.1.patch
>
>
> Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2881) Remove redundant key comparing in
SMBMapJoinOperator
Posted by "Navis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Navis updated HIVE-2881:
------------------------
Status: Patch Available (was: Open)
Passed all tests.
> Remove redundant key comparing in SMBMapJoinOperator
> ----------------------------------------------------
>
> Key: HIVE-2881
> URL: https://issues.apache.org/jira/browse/HIVE-2881
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2881.D2379.1.patch
>
>
> Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2881) Remove redundant key comparing in
SMBMapJoinOperator
Posted by "Namit Jain (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2881:
-----------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed. Thanks Navis
> Remove redundant key comparing in SMBMapJoinOperator
> ----------------------------------------------------
>
> Key: HIVE-2881
> URL: https://issues.apache.org/jira/browse/HIVE-2881
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2881.D2379.1.patch
>
>
> Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira