You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/11/01 20:59:26 UTC

[GitHub] [myfaces] volosied commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

volosied commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1299148181

   One item I found -- this code doesn't seem to handle `jakarta.faces.Resource` in ajax responses Such as 
   `<?xml version="1.0" encoding="UTF-8"?><partial-response id="j_id__v_0"><changes><update id="jakarta.faces.Resource"><![CDATA[<script src="/test-faces23-ajax-4466/jakarta.faces.resource/addedViaHead.js.xhtml?ln=spec1423"></script>]]></update>`. 
   
   Feel free to test spec1423.xhtml
   
   [test-faces23-ajax.war.zip](https://github.com/apache/myfaces/files/9913931/test-faces23-ajax.war.zip)
   
   Source code is from: https://github.com/jakartaee/faces/tree/4.0.1/tck/faces23/ajax
   
   Here's our current code for the resource check: https://github.com/apache/myfaces/blob/89c747e85615e3f33265e664c8361789f38ea7db/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxResponse.js#L531-L535 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org