You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/16 09:10:33 UTC
Review Request 64664: Updated logging for storage local resource
provider.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64664/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Updated logging for storage local resource provider.
Diffs
-----
src/resource_provider/manager.cpp 2a167aa5c50598758cab4ab6c13f1b1e33e692dd
src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a
Diff: https://reviews.apache.org/r/64664/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64664: Updated logging for storage local resource
provider.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64664/#review194011
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 64658.
Failed command: `python.exe .\support\apply-reviews.py -n -r 64658`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64664
Relevant logs:
- [apply-review-64658-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64664/logs/apply-review-64658-stdout.log):
```
error: patch failed: src/resource_provider/storage/provider.cpp:344
error: src/resource_provider/storage/provider.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Dec. 16, 2017, 9:10 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64664/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2017, 9:10 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated logging for storage local resource provider.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 2a167aa5c50598758cab4ab6c13f1b1e33e692dd
> src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a
>
>
> Diff: https://reviews.apache.org/r/64664/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64664: Updated logging for storage local resource
provider.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64664/#review194121
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 18, 2017, 11:57 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64664/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2017, 11:57 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated logging for storage local resource provider.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 2a167aa5c50598758cab4ab6c13f1b1e33e692dd
> src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a
>
>
> Diff: https://reviews.apache.org/r/64664/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64664: Updated logging for storage local resource
provider.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64664/
-----------------------------------------------------------
(Updated Dec. 18, 2017, 11:57 p.m.)
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Updated logging for storage local resource provider.
Diffs (updated)
-----
src/resource_provider/manager.cpp 2a167aa5c50598758cab4ab6c13f1b1e33e692dd
src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a
Diff: https://reviews.apache.org/r/64664/diff/2/
Changes: https://reviews.apache.org/r/64664/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64664: Updated logging for storage local resource
provider.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64664/
-----------------------------------------------------------
(Updated Dec. 16, 2017, 10:29 a.m.)
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Updated logging for storage local resource provider.
Diffs
-----
src/resource_provider/manager.cpp 2a167aa5c50598758cab4ab6c13f1b1e33e692dd
src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a
Diff: https://reviews.apache.org/r/64664/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao