[GitHub] [incubator-superset] villebro commented on a change in pull request #11060: refactor: remove useless filters in form_data

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #11060:
URL: https://github.com/apache/incubator-superset/pull/11060#discussion_r498085301



##########
File path: superset/viz.py
##########
@@ -341,6 +341,9 @@ def process_query_filters(self) -> None:
         utils.convert_legacy_filters_into_adhoc(self.form_data)
         merge_extra_filters(self.form_data)
         utils.split_adhoc_filters_into_base_filters(self.form_data)
+        # Normalize various filters, and then remove the original filters
+        self.form_data.pop("adhoc_filters", None)
+        self.form_data.pop("extra_filters", None)

Review comment:
       As we're mutating `self.form_data` in the above function calls, I wonder if this logic should be moved there?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org