You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/16 16:52:57 UTC

[GitHub] [incubator-nuttx] TimJTi commented on a diff in pull request #7595: SAMA5Dx ADC and TSD fixes

TimJTi commented on code in PR #7595:
URL: https://github.com/apache/incubator-nuttx/pull/7595#discussion_r1024261889


##########
arch/arm/src/sama5/sam_tsd.c:
##########
@@ -1655,7 +1735,11 @@ int sam_tsd_register(struct sam_adc_s *adc, int minor)
 
   /* Initialize the touchscreen device driver instance */
 
-  priv->adc = adc; /* Save the ADC device handle */
+  memset(priv, 0, sizeof(struct sam_tsd_s));

Review Comment:
   Thank you for pointing all these out. Should I do the squash before or after I make these corrections? Git is not my strong point!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org