You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:14:28 UTC

[GitHub] [incubator-superset] bkyryliuk opened a new issue #10441: React CRUD filters show duplicated values in the database filter

bkyryliuk opened a new issue #10441:
URL: https://github.com/apache/incubator-superset/issues/10441


   In the react views a new filter shows duplicated values while filtering on the database
   
   ### Expected results
   
   See distinct values in the filter
   
   ### Actual results
   
   what actually happens.
   ![image](https://user-images.githubusercontent.com/5727938/88587726-3c1d6b00-d00b-11ea-8452-fa174c7450eb.png)
   
   cc @nytai 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai edited a comment on issue #10441: React CRUD filters show duplicated values in the database filter

Posted by GitBox <gi...@apache.org>.
nytai edited a comment on issue #10441:
URL: https://github.com/apache/incubator-superset/issues/10441#issuecomment-664706834


   @bkyryliuk Thanks for syncing with me today. I believe I've addressed the 2 points in the linked PR. 
   
   1. We are now fetching the schema list from `/api/v1/dataset` which should return the schemas current being used in datasets. see: https://github.com/apache/incubator-superset/pull/10442/files#diff-ada33b933cd3086338ea8c3250ad87b3R86
   2. The extra results are due to removing pagination constraints via https://github.com/dropbox/incubator-superset-internal/commit/a7aec30301a363df96f9d723ba9a36d7894f5012. The endpoint being called has now moved over to `/ap1/v1/dataset/related/database` which should properly handle filtering. 
   
   Let me know if you'd like help confirming the PR fixes these issues. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on issue #10441: React CRUD filters show duplicated values in the database filter

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on issue #10441:
URL: https://github.com/apache/incubator-superset/issues/10441#issuecomment-664637979


   Synced with @nytai on slack:
   * https://github.com/dropbox/incubator-superset-internal/commit/a7aec30301a363df96f9d723ba9a36d7894f5012 causes weird behavior for me for the pagination, will revert that internally
   
   There are 2 small outstanding issues:
   1. http://localhost:8088/api/v1/database/schemas/?q=(filter:superset)  - this endpoint talked to external databases & may time out / do not have all schemas, probably it would be great to leverage `Table` table as a source of truth
   
   2. http://localhost:8088/api/v1/database/?q=(columns:!(database_name,id),filter:presto,keys:!(none),page:1) returns extra results & doesn't apply the filter
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10441: React CRUD filters show duplicated values in the database filter

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10441:
URL: https://github.com/apache/incubator-superset/issues/10441#issuecomment-664615321


   Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.97. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai closed issue #10441: React CRUD filters show duplicated values in the database filter

Posted by GitBox <gi...@apache.org>.
nytai closed issue #10441:
URL: https://github.com/apache/incubator-superset/issues/10441


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on issue #10441: React CRUD filters show duplicated values in the database filter

Posted by GitBox <gi...@apache.org>.
nytai commented on issue #10441:
URL: https://github.com/apache/incubator-superset/issues/10441#issuecomment-664706834


   @bkyryliuk Thanks for syncing with me today. I believe I've addressed the 2 points in the linked PR. 
   
   1. We are now fetching the schema list from `/api/v1/dataset` which should return the schemas current being used in datasets. see: https://github.com/apache/incubator-superset/pull/10442/files#diff-ada33b933cd3086338ea8c3250ad87b3R86
   2. The extra results are due to removing pagination constraints via https://github.com/dropbox/incubator-superset-internal/commit/a7aec30301a363df96f9d723ba9a36d7894f5012. The endpoint being called was also moved over to `/ap1/v1/dataset/related/database` which should properly handle filtering. 
   
   Let me know if you'd like help confirming the PR fixes these issues. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org