[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

[GitBox <gi...@apache.org>]

icefury71 commented on a change in pull request #6890:
URL: https://github.com/apache/incubator-pinot/pull/6890#discussion_r629032169



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -2117,6 +2117,17 @@ public void toggleQueryQuotaStateForBroker(String brokerInstanceName, String sta
     return consumingSegments;
   }
 
+  /**
+   * Utility function to return set of servers corresponding to a given segment.
+   */
+  public Set<String> getServersForSegment(String tableNameWithType, String segmentName) {
+    IdealState idealState = _helixAdmin.getResourceIdealState(_helixClusterName, tableNameWithType);

Review comment:
       The idea here is to get all the servers including those corresponding to segments in ERROR state. This is used to identify if there are any missing entries from the consuming segments API response.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org