You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/05/02 23:10:00 UTC
[jira] [Work logged] (GOBBLIN-1829) GaaSObservabilityEvent tracks Workunit preparation timer instead of Workunit creation timer
[ https://issues.apache.org/jira/browse/GOBBLIN-1829?focusedWorklogId=860194&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860194 ]
ASF GitHub Bot logged work on GOBBLIN-1829:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/23 23:09
Start Date: 02/May/23 23:09
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3691:
URL: https://github.com/apache/gobblin/pull/3691
…g track of work discovery time
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
In Gobblin framework, there are 2 events that look similar but do very different functions:
1. WorkUnitPreparationTimer - which serializes workunits and compacts them into MultiWorkUnits
2. WorkUnitCreationTimer - which tracks the time taken to discover the work needed for Gobblin to launch a job.
We want to track the latter in GaaS
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 860194)
Remaining Estimate: 0h
Time Spent: 10m
> GaaSObservabilityEvent tracks Workunit preparation timer instead of Workunit creation timer
> -------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1829
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1829
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In Gobblin framework, there are 2 events that look similar but do very different functions:
> 1. WorkUnitPreparationTimer - which serializes workunits and compacts them into MultiWorkUnits
> 2. WorkUnitCreationTimer - which tracks the time taken to discover the work needed for Gobblin to launch a job.
> We want to track #2 in metrics rather than #1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)