You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Attila Kreiner <at...@kreiner.hu> on 2017/09/01 15:16:09 UTC

Re: [VOTE] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

Hi All,

Looks like accepted. Updating KIP page.

Thx,
Attila

2017-08-31 19:22 GMT+02:00 Matthias J. Sax <ma...@confluent.io>:

> +1
>
> On 8/31/17 8:49 AM, Jason Gustafson wrote:
> > +1
> >
> > On Thu, Aug 31, 2017 at 8:36 AM, Mickael Maison <
> mickael.maison@gmail.com>
> > wrote:
> >
> >> +1 non binding
> >> Thanks
> >>
> >> On Thu, Aug 31, 2017 at 8:35 AM, Guozhang Wang <wa...@gmail.com>
> wrote:
> >>> +1
> >>>
> >>> On Thu, Aug 31, 2017 at 7:57 AM, Bill Bejeck <bb...@gmail.com>
> wrote:
> >>>
> >>>> +1
> >>>>
> >>>> Thanks,
> >>>> Bill
> >>>>
> >>>> On Thu, Aug 31, 2017 at 10:31 AM, Vahid S Hashemian <
> >>>> vahidhashemian@us.ibm.com> wrote:
> >>>>
> >>>>> +1 (non-binding)
> >>>>>
> >>>>> Thanks.
> >>>>> --Vahid
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>> From:   Molnár Bálint <mo...@gmail.com>
> >>>>> To:     dev@kafka.apache.org
> >>>>> Date:   08/31/2017 02:13 AM
> >>>>> Subject:        Re: [VOTE] KIP-191: KafkaConsumer.subscribe()
> overload
> >>>>> that takes just Pattern
> >>>>>
> >>>>>
> >>>>>
> >>>>> +1 (non-binding)
> >>>>>
> >>>>> 2017-08-31 10:33 GMT+02:00 Manikumar <ma...@gmail.com>:
> >>>>>
> >>>>>> +1 (non-binding)
> >>>>>>
> >>>>>> On Thu, Aug 31, 2017 at 1:53 PM, Ismael Juma <is...@gmail.com>
> >>>> wrote:
> >>>>>>
> >>>>>>> Thanks for the KIP, +1 (binding).
> >>>>>>>
> >>>>>>> Ismael
> >>>>>>>
> >>>>>>> On 31 Aug 2017 8:38 am, "Attila Kreiner" <at...@kreiner.hu>
> >> wrote:
> >>>>>>>
> >>>>>>> Hi All,
> >>>>>>>
> >>>>>>> Thx for the comments, I pretty much see a consensus here. So I'd
> >> like
> >>>>> to
> >>>>>>> start the vote for:
> >>>>>>>
> >>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.
> >>>>> apache.org_confluence_display_KAFKA_KIP-2D&d=DwIBaQ&c=jf_
> >>>>> iaSHvJObTbx-siA1ZOg&r=Q_itwloTQj3_xUKl7Nzswo6KE4Nj-
> kjJc7uSVcviKUc&m=-
> >>>>> tCQqMGtotzV0UuQdwhdYJ745XQzBJp5lz9O1oM9QgA&s=Wq-_8a-
> >>>>> 94g2UGfy8hlJcx9WMdxK0WJRZ7V2ex2qKPpY&e=
> >>>>>
> >>>>>>> 191%3A+KafkaConsumer.
> >>>>>>> subscribe%28%29+overload+that+takes+just+Pattern
> >>>>>>>
> >>>>>>> Cheers,
> >>>>>>> Attila
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> -- Guozhang
> >>
> >
>
>

Re: [VOTE] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

Posted by Guozhang Wang <wa...@gmail.com>.
Thanks for confirming.

On Wed, Sep 6, 2017 at 2:07 PM, Ismael Juma <is...@gmail.com> wrote:

> The PR for this was merged an hour or two ago.
>
> Ismael
>
> On 6 Sep 2017 9:51 pm, "Guozhang Wang" <wa...@gmail.com> wrote:
>
> > Thanks Attila,
> >
> > Please note that the feature freeze deadline is about two weeks away to
> > have your PR to be merged to trunk for the coming 1.0.0 release
> >
> >
> > Guozhang
> >
> >
> > On Wed, Sep 6, 2017 at 1:31 AM, Attila Kreiner <at...@kreiner.hu>
> wrote:
> >
> > > Hi All,
> > >
> > > No more votes received for this, so the final decision is: accepted.
> > >
> > > Thx,
> > > Attila
> > >
> > > 2017-09-02 6:57 GMT+02:00 Attila Kreiner <at...@kreiner.hu>:
> > >
> > > > Hi Jason,
> > > >
> > > > Sorry, I didn't know that one. Then I assume we should wait a few
> days
> > > > before moving forward.
> > > >
> > > > Regards,
> > > > Attila
> > > >
> > > > 2017-09-01 18:01 GMT+02:00 Jason Gustafson <ja...@confluent.io>:
> > > >
> > > >> Hi Attila,
> > > >>
> > > >> We should allow 3 days for the vote even if it is clear it will
> pass.
> > > >>
> > > >> Thanks,
> > > >> Jason
> > > >>
> > > >> On Fri, Sep 1, 2017 at 8:16 AM, Attila Kreiner <at...@kreiner.hu>
> > > wrote:
> > > >>
> > > >> > Hi All,
> > > >> >
> > > >> > Looks like accepted. Updating KIP page.
> > > >> >
> > > >> > Thx,
> > > >> > Attila
> > > >> >
> > > >> > 2017-08-31 19:22 GMT+02:00 Matthias J. Sax <matthias@confluent.io
> >:
> > > >> >
> > > >> > > +1
> > > >> > >
> > > >> > > On 8/31/17 8:49 AM, Jason Gustafson wrote:
> > > >> > > > +1
> > > >> > > >
> > > >> > > > On Thu, Aug 31, 2017 at 8:36 AM, Mickael Maison <
> > > >> > > mickael.maison@gmail.com>
> > > >> > > > wrote:
> > > >> > > >
> > > >> > > >> +1 non binding
> > > >> > > >> Thanks
> > > >> > > >>
> > > >> > > >> On Thu, Aug 31, 2017 at 8:35 AM, Guozhang Wang <
> > > wangguoz@gmail.com
> > > >> >
> > > >> > > wrote:
> > > >> > > >>> +1
> > > >> > > >>>
> > > >> > > >>> On Thu, Aug 31, 2017 at 7:57 AM, Bill Bejeck <
> > bbejeck@gmail.com
> > > >
> > > >> > > wrote:
> > > >> > > >>>
> > > >> > > >>>> +1
> > > >> > > >>>>
> > > >> > > >>>> Thanks,
> > > >> > > >>>> Bill
> > > >> > > >>>>
> > > >> > > >>>> On Thu, Aug 31, 2017 at 10:31 AM, Vahid S Hashemian <
> > > >> > > >>>> vahidhashemian@us.ibm.com> wrote:
> > > >> > > >>>>
> > > >> > > >>>>> +1 (non-binding)
> > > >> > > >>>>>
> > > >> > > >>>>> Thanks.
> > > >> > > >>>>> --Vahid
> > > >> > > >>>>>
> > > >> > > >>>>>
> > > >> > > >>>>>
> > > >> > > >>>>>
> > > >> > > >>>>> From:   Molnár Bálint <mo...@gmail.com>
> > > >> > > >>>>> To:     dev@kafka.apache.org
> > > >> > > >>>>> Date:   08/31/2017 02:13 AM
> > > >> > > >>>>> Subject:        Re: [VOTE] KIP-191:
> > KafkaConsumer.subscribe()
> > > >> > > overload
> > > >> > > >>>>> that takes just Pattern
> > > >> > > >>>>>
> > > >> > > >>>>>
> > > >> > > >>>>>
> > > >> > > >>>>> +1 (non-binding)
> > > >> > > >>>>>
> > > >> > > >>>>> 2017-08-31 10:33 GMT+02:00 Manikumar <
> > > manikumar.reddy@gmail.com
> > > >> >:
> > > >> > > >>>>>
> > > >> > > >>>>>> +1 (non-binding)
> > > >> > > >>>>>>
> > > >> > > >>>>>> On Thu, Aug 31, 2017 at 1:53 PM, Ismael Juma <
> > > >> ismaelj@gmail.com>
> > > >> > > >>>> wrote:
> > > >> > > >>>>>>
> > > >> > > >>>>>>> Thanks for the KIP, +1 (binding).
> > > >> > > >>>>>>>
> > > >> > > >>>>>>> Ismael
> > > >> > > >>>>>>>
> > > >> > > >>>>>>> On 31 Aug 2017 8:38 am, "Attila Kreiner" <
> > attila@kreiner.hu
> > > >
> > > >> > > >> wrote:
> > > >> > > >>>>>>>
> > > >> > > >>>>>>> Hi All,
> > > >> > > >>>>>>>
> > > >> > > >>>>>>> Thx for the comments, I pretty much see a consensus
> here.
> > So
> > > >> I'd
> > > >> > > >> like
> > > >> > > >>>>> to
> > > >> > > >>>>>>> start the vote for:
> > > >> > > >>>>>>>
> > > >> > > >>>>> https://urldefense.proofpoint.
> com/v2/url?u=https-3A__cwiki.
> > > >> > > >>>>> apache.org_confluence_display_KAFKA_KIP-2D&d=DwIBaQ&c=jf_
> > > >> > > >>>>> iaSHvJObTbx-siA1ZOg&r=Q_itwloTQj3_xUKl7Nzswo6KE4Nj-
> > > >> > > kjJc7uSVcviKUc&m=-
> > > >> > > >>>>> tCQqMGtotzV0UuQdwhdYJ745XQzBJp5lz9O1oM9QgA&s=Wq-_8a-
> > > >> > > >>>>> 94g2UGfy8hlJcx9WMdxK0WJRZ7V2ex2qKPpY&e=
> > > >> > > >>>>>
> > > >> > > >>>>>>> 191%3A+KafkaConsumer.
> > > >> > > >>>>>>> subscribe%28%29+overload+that+takes+just+Pattern
> > > >> > > >>>>>>>
> > > >> > > >>>>>>> Cheers,
> > > >> > > >>>>>>> Attila
> > > >> > > >>>>>>>
> > > >> > > >>>>>>
> > > >> > > >>>>>
> > > >> > > >>>>>
> > > >> > > >>>>>
> > > >> > > >>>>>
> > > >> > > >>>>>
> > > >> > > >>>>
> > > >> > > >>>
> > > >> > > >>>
> > > >> > > >>>
> > > >> > > >>> --
> > > >> > > >>> -- Guozhang
> > > >> > > >>
> > > >> > > >
> > > >> > >
> > > >> > >
> > > >> >
> > > >>
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > -- Guozhang
> >
>



-- 
-- Guozhang

Re: [VOTE] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

Posted by Ismael Juma <is...@gmail.com>.
The PR for this was merged an hour or two ago.

Ismael

On 6 Sep 2017 9:51 pm, "Guozhang Wang" <wa...@gmail.com> wrote:

> Thanks Attila,
>
> Please note that the feature freeze deadline is about two weeks away to
> have your PR to be merged to trunk for the coming 1.0.0 release
>
>
> Guozhang
>
>
> On Wed, Sep 6, 2017 at 1:31 AM, Attila Kreiner <at...@kreiner.hu> wrote:
>
> > Hi All,
> >
> > No more votes received for this, so the final decision is: accepted.
> >
> > Thx,
> > Attila
> >
> > 2017-09-02 6:57 GMT+02:00 Attila Kreiner <at...@kreiner.hu>:
> >
> > > Hi Jason,
> > >
> > > Sorry, I didn't know that one. Then I assume we should wait a few days
> > > before moving forward.
> > >
> > > Regards,
> > > Attila
> > >
> > > 2017-09-01 18:01 GMT+02:00 Jason Gustafson <ja...@confluent.io>:
> > >
> > >> Hi Attila,
> > >>
> > >> We should allow 3 days for the vote even if it is clear it will pass.
> > >>
> > >> Thanks,
> > >> Jason
> > >>
> > >> On Fri, Sep 1, 2017 at 8:16 AM, Attila Kreiner <at...@kreiner.hu>
> > wrote:
> > >>
> > >> > Hi All,
> > >> >
> > >> > Looks like accepted. Updating KIP page.
> > >> >
> > >> > Thx,
> > >> > Attila
> > >> >
> > >> > 2017-08-31 19:22 GMT+02:00 Matthias J. Sax <ma...@confluent.io>:
> > >> >
> > >> > > +1
> > >> > >
> > >> > > On 8/31/17 8:49 AM, Jason Gustafson wrote:
> > >> > > > +1
> > >> > > >
> > >> > > > On Thu, Aug 31, 2017 at 8:36 AM, Mickael Maison <
> > >> > > mickael.maison@gmail.com>
> > >> > > > wrote:
> > >> > > >
> > >> > > >> +1 non binding
> > >> > > >> Thanks
> > >> > > >>
> > >> > > >> On Thu, Aug 31, 2017 at 8:35 AM, Guozhang Wang <
> > wangguoz@gmail.com
> > >> >
> > >> > > wrote:
> > >> > > >>> +1
> > >> > > >>>
> > >> > > >>> On Thu, Aug 31, 2017 at 7:57 AM, Bill Bejeck <
> bbejeck@gmail.com
> > >
> > >> > > wrote:
> > >> > > >>>
> > >> > > >>>> +1
> > >> > > >>>>
> > >> > > >>>> Thanks,
> > >> > > >>>> Bill
> > >> > > >>>>
> > >> > > >>>> On Thu, Aug 31, 2017 at 10:31 AM, Vahid S Hashemian <
> > >> > > >>>> vahidhashemian@us.ibm.com> wrote:
> > >> > > >>>>
> > >> > > >>>>> +1 (non-binding)
> > >> > > >>>>>
> > >> > > >>>>> Thanks.
> > >> > > >>>>> --Vahid
> > >> > > >>>>>
> > >> > > >>>>>
> > >> > > >>>>>
> > >> > > >>>>>
> > >> > > >>>>> From:   Molnár Bálint <mo...@gmail.com>
> > >> > > >>>>> To:     dev@kafka.apache.org
> > >> > > >>>>> Date:   08/31/2017 02:13 AM
> > >> > > >>>>> Subject:        Re: [VOTE] KIP-191:
> KafkaConsumer.subscribe()
> > >> > > overload
> > >> > > >>>>> that takes just Pattern
> > >> > > >>>>>
> > >> > > >>>>>
> > >> > > >>>>>
> > >> > > >>>>> +1 (non-binding)
> > >> > > >>>>>
> > >> > > >>>>> 2017-08-31 10:33 GMT+02:00 Manikumar <
> > manikumar.reddy@gmail.com
> > >> >:
> > >> > > >>>>>
> > >> > > >>>>>> +1 (non-binding)
> > >> > > >>>>>>
> > >> > > >>>>>> On Thu, Aug 31, 2017 at 1:53 PM, Ismael Juma <
> > >> ismaelj@gmail.com>
> > >> > > >>>> wrote:
> > >> > > >>>>>>
> > >> > > >>>>>>> Thanks for the KIP, +1 (binding).
> > >> > > >>>>>>>
> > >> > > >>>>>>> Ismael
> > >> > > >>>>>>>
> > >> > > >>>>>>> On 31 Aug 2017 8:38 am, "Attila Kreiner" <
> attila@kreiner.hu
> > >
> > >> > > >> wrote:
> > >> > > >>>>>>>
> > >> > > >>>>>>> Hi All,
> > >> > > >>>>>>>
> > >> > > >>>>>>> Thx for the comments, I pretty much see a consensus here.
> So
> > >> I'd
> > >> > > >> like
> > >> > > >>>>> to
> > >> > > >>>>>>> start the vote for:
> > >> > > >>>>>>>
> > >> > > >>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.
> > >> > > >>>>> apache.org_confluence_display_KAFKA_KIP-2D&d=DwIBaQ&c=jf_
> > >> > > >>>>> iaSHvJObTbx-siA1ZOg&r=Q_itwloTQj3_xUKl7Nzswo6KE4Nj-
> > >> > > kjJc7uSVcviKUc&m=-
> > >> > > >>>>> tCQqMGtotzV0UuQdwhdYJ745XQzBJp5lz9O1oM9QgA&s=Wq-_8a-
> > >> > > >>>>> 94g2UGfy8hlJcx9WMdxK0WJRZ7V2ex2qKPpY&e=
> > >> > > >>>>>
> > >> > > >>>>>>> 191%3A+KafkaConsumer.
> > >> > > >>>>>>> subscribe%28%29+overload+that+takes+just+Pattern
> > >> > > >>>>>>>
> > >> > > >>>>>>> Cheers,
> > >> > > >>>>>>> Attila
> > >> > > >>>>>>>
> > >> > > >>>>>>
> > >> > > >>>>>
> > >> > > >>>>>
> > >> > > >>>>>
> > >> > > >>>>>
> > >> > > >>>>>
> > >> > > >>>>
> > >> > > >>>
> > >> > > >>>
> > >> > > >>>
> > >> > > >>> --
> > >> > > >>> -- Guozhang
> > >> > > >>
> > >> > > >
> > >> > >
> > >> > >
> > >> >
> > >>
> > >
> > >
> >
>
>
>
> --
> -- Guozhang
>

Re: [VOTE] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

Posted by Guozhang Wang <wa...@gmail.com>.
Thanks Attila,

Please note that the feature freeze deadline is about two weeks away to
have your PR to be merged to trunk for the coming 1.0.0 release


Guozhang


On Wed, Sep 6, 2017 at 1:31 AM, Attila Kreiner <at...@kreiner.hu> wrote:

> Hi All,
>
> No more votes received for this, so the final decision is: accepted.
>
> Thx,
> Attila
>
> 2017-09-02 6:57 GMT+02:00 Attila Kreiner <at...@kreiner.hu>:
>
> > Hi Jason,
> >
> > Sorry, I didn't know that one. Then I assume we should wait a few days
> > before moving forward.
> >
> > Regards,
> > Attila
> >
> > 2017-09-01 18:01 GMT+02:00 Jason Gustafson <ja...@confluent.io>:
> >
> >> Hi Attila,
> >>
> >> We should allow 3 days for the vote even if it is clear it will pass.
> >>
> >> Thanks,
> >> Jason
> >>
> >> On Fri, Sep 1, 2017 at 8:16 AM, Attila Kreiner <at...@kreiner.hu>
> wrote:
> >>
> >> > Hi All,
> >> >
> >> > Looks like accepted. Updating KIP page.
> >> >
> >> > Thx,
> >> > Attila
> >> >
> >> > 2017-08-31 19:22 GMT+02:00 Matthias J. Sax <ma...@confluent.io>:
> >> >
> >> > > +1
> >> > >
> >> > > On 8/31/17 8:49 AM, Jason Gustafson wrote:
> >> > > > +1
> >> > > >
> >> > > > On Thu, Aug 31, 2017 at 8:36 AM, Mickael Maison <
> >> > > mickael.maison@gmail.com>
> >> > > > wrote:
> >> > > >
> >> > > >> +1 non binding
> >> > > >> Thanks
> >> > > >>
> >> > > >> On Thu, Aug 31, 2017 at 8:35 AM, Guozhang Wang <
> wangguoz@gmail.com
> >> >
> >> > > wrote:
> >> > > >>> +1
> >> > > >>>
> >> > > >>> On Thu, Aug 31, 2017 at 7:57 AM, Bill Bejeck <bbejeck@gmail.com
> >
> >> > > wrote:
> >> > > >>>
> >> > > >>>> +1
> >> > > >>>>
> >> > > >>>> Thanks,
> >> > > >>>> Bill
> >> > > >>>>
> >> > > >>>> On Thu, Aug 31, 2017 at 10:31 AM, Vahid S Hashemian <
> >> > > >>>> vahidhashemian@us.ibm.com> wrote:
> >> > > >>>>
> >> > > >>>>> +1 (non-binding)
> >> > > >>>>>
> >> > > >>>>> Thanks.
> >> > > >>>>> --Vahid
> >> > > >>>>>
> >> > > >>>>>
> >> > > >>>>>
> >> > > >>>>>
> >> > > >>>>> From:   Molnár Bálint <mo...@gmail.com>
> >> > > >>>>> To:     dev@kafka.apache.org
> >> > > >>>>> Date:   08/31/2017 02:13 AM
> >> > > >>>>> Subject:        Re: [VOTE] KIP-191: KafkaConsumer.subscribe()
> >> > > overload
> >> > > >>>>> that takes just Pattern
> >> > > >>>>>
> >> > > >>>>>
> >> > > >>>>>
> >> > > >>>>> +1 (non-binding)
> >> > > >>>>>
> >> > > >>>>> 2017-08-31 10:33 GMT+02:00 Manikumar <
> manikumar.reddy@gmail.com
> >> >:
> >> > > >>>>>
> >> > > >>>>>> +1 (non-binding)
> >> > > >>>>>>
> >> > > >>>>>> On Thu, Aug 31, 2017 at 1:53 PM, Ismael Juma <
> >> ismaelj@gmail.com>
> >> > > >>>> wrote:
> >> > > >>>>>>
> >> > > >>>>>>> Thanks for the KIP, +1 (binding).
> >> > > >>>>>>>
> >> > > >>>>>>> Ismael
> >> > > >>>>>>>
> >> > > >>>>>>> On 31 Aug 2017 8:38 am, "Attila Kreiner" <attila@kreiner.hu
> >
> >> > > >> wrote:
> >> > > >>>>>>>
> >> > > >>>>>>> Hi All,
> >> > > >>>>>>>
> >> > > >>>>>>> Thx for the comments, I pretty much see a consensus here. So
> >> I'd
> >> > > >> like
> >> > > >>>>> to
> >> > > >>>>>>> start the vote for:
> >> > > >>>>>>>
> >> > > >>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.
> >> > > >>>>> apache.org_confluence_display_KAFKA_KIP-2D&d=DwIBaQ&c=jf_
> >> > > >>>>> iaSHvJObTbx-siA1ZOg&r=Q_itwloTQj3_xUKl7Nzswo6KE4Nj-
> >> > > kjJc7uSVcviKUc&m=-
> >> > > >>>>> tCQqMGtotzV0UuQdwhdYJ745XQzBJp5lz9O1oM9QgA&s=Wq-_8a-
> >> > > >>>>> 94g2UGfy8hlJcx9WMdxK0WJRZ7V2ex2qKPpY&e=
> >> > > >>>>>
> >> > > >>>>>>> 191%3A+KafkaConsumer.
> >> > > >>>>>>> subscribe%28%29+overload+that+takes+just+Pattern
> >> > > >>>>>>>
> >> > > >>>>>>> Cheers,
> >> > > >>>>>>> Attila
> >> > > >>>>>>>
> >> > > >>>>>>
> >> > > >>>>>
> >> > > >>>>>
> >> > > >>>>>
> >> > > >>>>>
> >> > > >>>>>
> >> > > >>>>
> >> > > >>>
> >> > > >>>
> >> > > >>>
> >> > > >>> --
> >> > > >>> -- Guozhang
> >> > > >>
> >> > > >
> >> > >
> >> > >
> >> >
> >>
> >
> >
>



-- 
-- Guozhang

Re: [VOTE] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

Posted by Attila Kreiner <at...@kreiner.hu>.
Hi All,

No more votes received for this, so the final decision is: accepted.

Thx,
Attila

2017-09-02 6:57 GMT+02:00 Attila Kreiner <at...@kreiner.hu>:

> Hi Jason,
>
> Sorry, I didn't know that one. Then I assume we should wait a few days
> before moving forward.
>
> Regards,
> Attila
>
> 2017-09-01 18:01 GMT+02:00 Jason Gustafson <ja...@confluent.io>:
>
>> Hi Attila,
>>
>> We should allow 3 days for the vote even if it is clear it will pass.
>>
>> Thanks,
>> Jason
>>
>> On Fri, Sep 1, 2017 at 8:16 AM, Attila Kreiner <at...@kreiner.hu> wrote:
>>
>> > Hi All,
>> >
>> > Looks like accepted. Updating KIP page.
>> >
>> > Thx,
>> > Attila
>> >
>> > 2017-08-31 19:22 GMT+02:00 Matthias J. Sax <ma...@confluent.io>:
>> >
>> > > +1
>> > >
>> > > On 8/31/17 8:49 AM, Jason Gustafson wrote:
>> > > > +1
>> > > >
>> > > > On Thu, Aug 31, 2017 at 8:36 AM, Mickael Maison <
>> > > mickael.maison@gmail.com>
>> > > > wrote:
>> > > >
>> > > >> +1 non binding
>> > > >> Thanks
>> > > >>
>> > > >> On Thu, Aug 31, 2017 at 8:35 AM, Guozhang Wang <wangguoz@gmail.com
>> >
>> > > wrote:
>> > > >>> +1
>> > > >>>
>> > > >>> On Thu, Aug 31, 2017 at 7:57 AM, Bill Bejeck <bb...@gmail.com>
>> > > wrote:
>> > > >>>
>> > > >>>> +1
>> > > >>>>
>> > > >>>> Thanks,
>> > > >>>> Bill
>> > > >>>>
>> > > >>>> On Thu, Aug 31, 2017 at 10:31 AM, Vahid S Hashemian <
>> > > >>>> vahidhashemian@us.ibm.com> wrote:
>> > > >>>>
>> > > >>>>> +1 (non-binding)
>> > > >>>>>
>> > > >>>>> Thanks.
>> > > >>>>> --Vahid
>> > > >>>>>
>> > > >>>>>
>> > > >>>>>
>> > > >>>>>
>> > > >>>>> From:   Molnár Bálint <mo...@gmail.com>
>> > > >>>>> To:     dev@kafka.apache.org
>> > > >>>>> Date:   08/31/2017 02:13 AM
>> > > >>>>> Subject:        Re: [VOTE] KIP-191: KafkaConsumer.subscribe()
>> > > overload
>> > > >>>>> that takes just Pattern
>> > > >>>>>
>> > > >>>>>
>> > > >>>>>
>> > > >>>>> +1 (non-binding)
>> > > >>>>>
>> > > >>>>> 2017-08-31 10:33 GMT+02:00 Manikumar <manikumar.reddy@gmail.com
>> >:
>> > > >>>>>
>> > > >>>>>> +1 (non-binding)
>> > > >>>>>>
>> > > >>>>>> On Thu, Aug 31, 2017 at 1:53 PM, Ismael Juma <
>> ismaelj@gmail.com>
>> > > >>>> wrote:
>> > > >>>>>>
>> > > >>>>>>> Thanks for the KIP, +1 (binding).
>> > > >>>>>>>
>> > > >>>>>>> Ismael
>> > > >>>>>>>
>> > > >>>>>>> On 31 Aug 2017 8:38 am, "Attila Kreiner" <at...@kreiner.hu>
>> > > >> wrote:
>> > > >>>>>>>
>> > > >>>>>>> Hi All,
>> > > >>>>>>>
>> > > >>>>>>> Thx for the comments, I pretty much see a consensus here. So
>> I'd
>> > > >> like
>> > > >>>>> to
>> > > >>>>>>> start the vote for:
>> > > >>>>>>>
>> > > >>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.
>> > > >>>>> apache.org_confluence_display_KAFKA_KIP-2D&d=DwIBaQ&c=jf_
>> > > >>>>> iaSHvJObTbx-siA1ZOg&r=Q_itwloTQj3_xUKl7Nzswo6KE4Nj-
>> > > kjJc7uSVcviKUc&m=-
>> > > >>>>> tCQqMGtotzV0UuQdwhdYJ745XQzBJp5lz9O1oM9QgA&s=Wq-_8a-
>> > > >>>>> 94g2UGfy8hlJcx9WMdxK0WJRZ7V2ex2qKPpY&e=
>> > > >>>>>
>> > > >>>>>>> 191%3A+KafkaConsumer.
>> > > >>>>>>> subscribe%28%29+overload+that+takes+just+Pattern
>> > > >>>>>>>
>> > > >>>>>>> Cheers,
>> > > >>>>>>> Attila
>> > > >>>>>>>
>> > > >>>>>>
>> > > >>>>>
>> > > >>>>>
>> > > >>>>>
>> > > >>>>>
>> > > >>>>>
>> > > >>>>
>> > > >>>
>> > > >>>
>> > > >>>
>> > > >>> --
>> > > >>> -- Guozhang
>> > > >>
>> > > >
>> > >
>> > >
>> >
>>
>
>

Re: [VOTE] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

Posted by Attila Kreiner <at...@kreiner.hu>.
Hi Jason,

Sorry, I didn't know that one. Then I assume we should wait a few days
before moving forward.

Regards,
Attila

2017-09-01 18:01 GMT+02:00 Jason Gustafson <ja...@confluent.io>:

> Hi Attila,
>
> We should allow 3 days for the vote even if it is clear it will pass.
>
> Thanks,
> Jason
>
> On Fri, Sep 1, 2017 at 8:16 AM, Attila Kreiner <at...@kreiner.hu> wrote:
>
> > Hi All,
> >
> > Looks like accepted. Updating KIP page.
> >
> > Thx,
> > Attila
> >
> > 2017-08-31 19:22 GMT+02:00 Matthias J. Sax <ma...@confluent.io>:
> >
> > > +1
> > >
> > > On 8/31/17 8:49 AM, Jason Gustafson wrote:
> > > > +1
> > > >
> > > > On Thu, Aug 31, 2017 at 8:36 AM, Mickael Maison <
> > > mickael.maison@gmail.com>
> > > > wrote:
> > > >
> > > >> +1 non binding
> > > >> Thanks
> > > >>
> > > >> On Thu, Aug 31, 2017 at 8:35 AM, Guozhang Wang <wa...@gmail.com>
> > > wrote:
> > > >>> +1
> > > >>>
> > > >>> On Thu, Aug 31, 2017 at 7:57 AM, Bill Bejeck <bb...@gmail.com>
> > > wrote:
> > > >>>
> > > >>>> +1
> > > >>>>
> > > >>>> Thanks,
> > > >>>> Bill
> > > >>>>
> > > >>>> On Thu, Aug 31, 2017 at 10:31 AM, Vahid S Hashemian <
> > > >>>> vahidhashemian@us.ibm.com> wrote:
> > > >>>>
> > > >>>>> +1 (non-binding)
> > > >>>>>
> > > >>>>> Thanks.
> > > >>>>> --Vahid
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>> From:   Molnár Bálint <mo...@gmail.com>
> > > >>>>> To:     dev@kafka.apache.org
> > > >>>>> Date:   08/31/2017 02:13 AM
> > > >>>>> Subject:        Re: [VOTE] KIP-191: KafkaConsumer.subscribe()
> > > overload
> > > >>>>> that takes just Pattern
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>> +1 (non-binding)
> > > >>>>>
> > > >>>>> 2017-08-31 10:33 GMT+02:00 Manikumar <manikumar.reddy@gmail.com
> >:
> > > >>>>>
> > > >>>>>> +1 (non-binding)
> > > >>>>>>
> > > >>>>>> On Thu, Aug 31, 2017 at 1:53 PM, Ismael Juma <ismaelj@gmail.com
> >
> > > >>>> wrote:
> > > >>>>>>
> > > >>>>>>> Thanks for the KIP, +1 (binding).
> > > >>>>>>>
> > > >>>>>>> Ismael
> > > >>>>>>>
> > > >>>>>>> On 31 Aug 2017 8:38 am, "Attila Kreiner" <at...@kreiner.hu>
> > > >> wrote:
> > > >>>>>>>
> > > >>>>>>> Hi All,
> > > >>>>>>>
> > > >>>>>>> Thx for the comments, I pretty much see a consensus here. So
> I'd
> > > >> like
> > > >>>>> to
> > > >>>>>>> start the vote for:
> > > >>>>>>>
> > > >>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.
> > > >>>>> apache.org_confluence_display_KAFKA_KIP-2D&d=DwIBaQ&c=jf_
> > > >>>>> iaSHvJObTbx-siA1ZOg&r=Q_itwloTQj3_xUKl7Nzswo6KE4Nj-
> > > kjJc7uSVcviKUc&m=-
> > > >>>>> tCQqMGtotzV0UuQdwhdYJ745XQzBJp5lz9O1oM9QgA&s=Wq-_8a-
> > > >>>>> 94g2UGfy8hlJcx9WMdxK0WJRZ7V2ex2qKPpY&e=
> > > >>>>>
> > > >>>>>>> 191%3A+KafkaConsumer.
> > > >>>>>>> subscribe%28%29+overload+that+takes+just+Pattern
> > > >>>>>>>
> > > >>>>>>> Cheers,
> > > >>>>>>> Attila
> > > >>>>>>>
> > > >>>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>
> > > >>>
> > > >>>
> > > >>>
> > > >>> --
> > > >>> -- Guozhang
> > > >>
> > > >
> > >
> > >
> >
>

Re: [VOTE] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

Posted by Jason Gustafson <ja...@confluent.io>.
Hi Attila,

We should allow 3 days for the vote even if it is clear it will pass.

Thanks,
Jason

On Fri, Sep 1, 2017 at 8:16 AM, Attila Kreiner <at...@kreiner.hu> wrote:

> Hi All,
>
> Looks like accepted. Updating KIP page.
>
> Thx,
> Attila
>
> 2017-08-31 19:22 GMT+02:00 Matthias J. Sax <ma...@confluent.io>:
>
> > +1
> >
> > On 8/31/17 8:49 AM, Jason Gustafson wrote:
> > > +1
> > >
> > > On Thu, Aug 31, 2017 at 8:36 AM, Mickael Maison <
> > mickael.maison@gmail.com>
> > > wrote:
> > >
> > >> +1 non binding
> > >> Thanks
> > >>
> > >> On Thu, Aug 31, 2017 at 8:35 AM, Guozhang Wang <wa...@gmail.com>
> > wrote:
> > >>> +1
> > >>>
> > >>> On Thu, Aug 31, 2017 at 7:57 AM, Bill Bejeck <bb...@gmail.com>
> > wrote:
> > >>>
> > >>>> +1
> > >>>>
> > >>>> Thanks,
> > >>>> Bill
> > >>>>
> > >>>> On Thu, Aug 31, 2017 at 10:31 AM, Vahid S Hashemian <
> > >>>> vahidhashemian@us.ibm.com> wrote:
> > >>>>
> > >>>>> +1 (non-binding)
> > >>>>>
> > >>>>> Thanks.
> > >>>>> --Vahid
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> From:   Molnár Bálint <mo...@gmail.com>
> > >>>>> To:     dev@kafka.apache.org
> > >>>>> Date:   08/31/2017 02:13 AM
> > >>>>> Subject:        Re: [VOTE] KIP-191: KafkaConsumer.subscribe()
> > overload
> > >>>>> that takes just Pattern
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> +1 (non-binding)
> > >>>>>
> > >>>>> 2017-08-31 10:33 GMT+02:00 Manikumar <ma...@gmail.com>:
> > >>>>>
> > >>>>>> +1 (non-binding)
> > >>>>>>
> > >>>>>> On Thu, Aug 31, 2017 at 1:53 PM, Ismael Juma <is...@gmail.com>
> > >>>> wrote:
> > >>>>>>
> > >>>>>>> Thanks for the KIP, +1 (binding).
> > >>>>>>>
> > >>>>>>> Ismael
> > >>>>>>>
> > >>>>>>> On 31 Aug 2017 8:38 am, "Attila Kreiner" <at...@kreiner.hu>
> > >> wrote:
> > >>>>>>>
> > >>>>>>> Hi All,
> > >>>>>>>
> > >>>>>>> Thx for the comments, I pretty much see a consensus here. So I'd
> > >> like
> > >>>>> to
> > >>>>>>> start the vote for:
> > >>>>>>>
> > >>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.
> > >>>>> apache.org_confluence_display_KAFKA_KIP-2D&d=DwIBaQ&c=jf_
> > >>>>> iaSHvJObTbx-siA1ZOg&r=Q_itwloTQj3_xUKl7Nzswo6KE4Nj-
> > kjJc7uSVcviKUc&m=-
> > >>>>> tCQqMGtotzV0UuQdwhdYJ745XQzBJp5lz9O1oM9QgA&s=Wq-_8a-
> > >>>>> 94g2UGfy8hlJcx9WMdxK0WJRZ7V2ex2qKPpY&e=
> > >>>>>
> > >>>>>>> 191%3A+KafkaConsumer.
> > >>>>>>> subscribe%28%29+overload+that+takes+just+Pattern
> > >>>>>>>
> > >>>>>>> Cheers,
> > >>>>>>> Attila
> > >>>>>>>
> > >>>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> -- Guozhang
> > >>
> > >
> >
> >
>